Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantstamp Generic Raffle audit #782

Merged
merged 12 commits into from
Sep 30, 2022
Merged

Quantstamp Generic Raffle audit #782

merged 12 commits into from
Sep 30, 2022

Conversation

ioanaverebi
Copy link
Contributor

@ioanaverebi ioanaverebi commented Sep 26, 2022 •
edited by abarbatei
Loading

Description

Clickup task

Checklist:

  • Pull Request references Jira issue
  • Pull Request applies to a single purpose
  • I've added comments to my code where needed
  • I've updated any relevant docs
  • I've added tests to show that my changes achieve the desired results
  • I've reviewed my code
  • I've followed established naming conventions and formatting
  • I've generated a coverage report and included a screenshot
  • All tests are passing locally

balajmarius and others added 3 commits September 28, 2022 09:00
@balajmarius @atkinsonholly @ioanaverebi
implement ERC2771 to generic raffle contract (#734)
a977eab 
* implement ERC2771 to generic raffle contract

* raffle: use erc2771handler

* steve aoki: added trusted forwarder

* poc: update deploy script

* deployment: goerli tags RaffleSteveAoki

Co-authored-by: atkinsonholly <atkinsonholly@gmail.com>
@ioanaverebi
QSP-2 Missing Input Validation
7fc29c2
@ioanaverebi
QSP-6 Inheriting From Non-Upgradeable Contracts
cbfe658
@ioanaverebi ioanaverebi merged commit 3690801 into master Sep 30, 2022
@ioanaverebi ioanaverebi deleted the task/quantstamp-raffle-audit branch September 30, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtemian vtemian vtemian approved these changes

@mvanmeerbeck mvanmeerbeck mvanmeerbeck approved these changes

@balajmarius balajmarius balajmarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ioanaverebi @vtemian @mvanmeerbeck @balajmarius