Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import IPython lazily #84

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Import IPython lazily #84

merged 1 commit into from
Jan 25, 2018

Conversation

methane
Copy link
Contributor

@methane methane commented Jan 18, 2018

import dotenv takes long time when IPython is installed.
This affects pypa/pipenv now. (ref)

This pull request imports dotenv.ipython lazily to avoid overhead.

@coveralls
Copy link

coveralls commented Jan 18, 2018

Coverage Status

Coverage increased (+0.9%) to 86.224% when pulling 11dd923 on methane:lazy-ipython into 6eb1698 on theskumar:master.

methane added a commit to methane/pipenv that referenced this pull request Jan 18, 2018
@theskumar
Copy link
Owner

Thanks @methane for the PR, i'll include it after testing and add little documentation.

As far as pypa/pipenv is concerned, you may need to submit a separate PR to that repo, as it doesn't include this library directly but a copy of it: https://github.com/pypa/pipenv/tree/master/pipenv/patched/dotenv

Cheers,

@theskumar
Copy link
Owner

Oh. I see you already have PR open for it :)

@theskumar theskumar merged commit 58c0df1 into theskumar:master Jan 25, 2018
nateprewitt pushed a commit to nateprewitt/pipenv that referenced this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants