ASoC: soc-pcm: harden dpcm_be_connect #3735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A kernel oops can happen in dpcm_be_connect() when changing the substream atomicity. Add a check and report an error log when the FE or BE substream is not initialized. Reported-by: Alex Natalsson <harmoniesworlds@gmail.com> Link: https://lore.kernel.org/alsa-devel/15259e38-eccf-d294-a330-a48b5bbbdedf@linux.intel.com/ Fixes: bbf7d3b ("ASoC: soc-pcm: align BE 'atomicity' with that of the FE") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
requested review from
lgirdwood,
ranj063,
kv2019i,
dbaluta,
bardliao,
ujfalusi,
ajitkupandey,
kuanhsuncheng and
yaochunhung
as code owners
ujfalusi
reviewed
Jul 4, 2022
| if (!be_substream) { | ||
| dev_err(be->dev, "%s: be_substream not initialized for direction %d\n", __func__, stream); | ||
| return -EINVAL; | ||
| } |
There was a problem hiding this comment.
@plbossart, before bbf7d3b neither fe or be stream was checked, no error was generated if any of them was initialized at a later time.
Should we only protect the atomicity check and fixup with if (fe_substream && be_substream) { } ?
There was a problem hiding this comment.
If the BE substream can be initialized later, then the atomicity check is done in the wrong location. It would happen that we have a later initialization of an atomic BE and that would throw all kinds of errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A kernel oops can happen in dpcm_be_connect() when changing the
substream atomicity. Add a check and report an error log when the FE
or BE substream is not initialized.
Reported-by: Alex Natalsson harmoniesworlds@gmail.com
Link: https://lore.kernel.org/alsa-devel/15259e38-eccf-d294-a330-a48b5bbbdedf@linux.intel.com/
Fixes: bbf7d3b ("ASoC: soc-pcm: align BE 'atomicity' with that of the FE")
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com