Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream/test const #4993

Closed
wants to merge 7 commits into from
Closed

Upstream/test const #4993

wants to merge 7 commits into from

Commits on May 13, 2024

  1. ASoC: topology: Constify an argument of snd_soc_tplg_component_load() 

    snd_soc_tplg_component_load() does not modify its "*ops" argument. It
only read some values and stores it in "soc_tplg.ops".

This argument and the ops field in "struct soc_tplg" can be made const.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    @tititiou36 @plbossart
    tititiou36 authored and plbossart committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c352866 View commit details
    Browse the repository at this point in the history

  2. ASoC: Intel: avs: Constify struct snd_soc_tplg_ops 

    Constifying "struct snd_soc_tplg_ops" moves some data to a read-only
section, so increase overall security.

On a x86_64, with allmodconfig:
Before:
   text	   data	    bss	    dec	    hex	filename
  28046	    794	      0	  28840	   70a8	sound/soc/intel/avs/topology.o

After:
   text	   data	    bss	    dec	    hex	filename
  28206	    614	      0	  28820	   7094	sound/soc/intel/avs/topology.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    @tititiou36 @plbossart
    tititiou36 authored and plbossart committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e38d880 View commit details
    Browse the repository at this point in the history

  3. ASoC: qdsp6: audioreach: Constify struct snd_soc_tplg_ops 

    Constifying "struct snd_soc_tplg_ops" moves some data to a read-only
section, so increase overall security.

On a x86_64, with allmodconfig:
Before:
   text	   data	    bss	    dec	    hex	filename
  19942	    832	      0	  20774	   5126	sound/soc/qcom/qdsp6/topology.o

After:
   text	   data	    bss	    dec	    hex	filename
  20102	    652	      0	  20754	   5112	sound/soc/qcom/qdsp6/topology.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    @tititiou36 @plbossart
    tititiou36 authored and plbossart committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a03d235 View commit details
    Browse the repository at this point in the history

  4. ASoC: Intel: Skylake: Constify struct snd_soc_tplg_ops 

    Constifying "struct snd_soc_tplg_ops" moves some data to a read-only
section, so increase overall security.

On a x86_64, with allmodconfig:
Before:
   text	   data	    bss	    dec	    hex	filename
  58844	   5282	     56	  64182	   fab6	sound/soc/intel/skylake/skl-topology.o

After:
   text	   data	    bss	    dec	    hex	filename
  59004	   5122	     56	  64182	   fab6	sound/soc/intel/skylake/skl-topology.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    @tititiou36 @plbossart
    tititiou36 authored and plbossart committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3ff731f View commit details
    Browse the repository at this point in the history

  5. ASoC: SOF: topology: Constify struct snd_soc_tplg_ops 

    Constifying "struct snd_soc_tplg_ops" moves some data to a read-only
section, so increase overall security.

On a x86_64, with allmodconfig:
Before:
   text	   data	    bss	    dec	    hex	filename
  44519	   2888	     48	  47455	   b95f	sound/soc/sof/topology.o

After:
   text	   data	    bss	    dec	    hex	filename
  44839	   2552	     48	  47439	   b94f	sound/soc/sof/topology.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    @tititiou36 @plbossart
    tititiou36 authored and plbossart committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7f09fdb View commit details
    Browse the repository at this point in the history

  6. const_structs.checkpatch: add snd_soc_tplg_ops 

    Now that the soc-topology can handle "const struct snd_soc_tplg_ops" make
sure that new usages of the struct already enter the tree as const.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    @tititiou36 @plbossart
    tititiou36 authored and plbossart committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ef2fc84 View commit details
    Browse the repository at this point in the history

  7. ASoC: intel: Constify struct snd_soc_ops 

    Constifying "struct snd_soc_ops" moves some data to a read-only section, so
increase overall security.

This structure is also part of scripts/const_structs.checkpatch.

As an example, on a x86_64, with allmodconfig:
Before:
   text	   data	    bss	    dec	    hex	filename
   6315	   3696	      0	  10011	   271b	sound/soc/intel/boards/ehl_rt5660.o

After:
   text	   data	    bss	    dec	    hex	filename
   6379	   3648	      0	  10027	   272b	sound/soc/intel/boards/ehl_rt5660.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    @tititiou36 @plbossart
    tititiou36 authored and plbossart committed May 13, 2024
    Configuration menu
    Copy the full SHA
    97e1c76 View commit details
    Browse the repository at this point in the history