-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-case: improve Chrome OS compatibility #684
Conversation
We are not using dmesg to collect logs now, so don't need to clear the log buffer. Signed-off-by: Chao Song <chao.song@linux.intel.com>
Under Chrome OS, need root permission to run journalctl. Signed-off-by: Chao Song <chao.song@linux.intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aiChaoSONG.
maybe that's a stretch but does this help with Fedora compatibility as well? What's missing now?
Some commands in sof-test need root privilege, so they are executed as The same thing needs to be done for Fedora and Chrome, but there is not a sudo group on these two distros as Ubuntu, what I do is to
After above two steps, you can run sof-test on fedora, just as you run it on ubuntu. |
d39f8c2
On Chrome OS, we need to execute lspci with sudo, this command is not found for normal user. Signed-off-by: Chao Song <chao.song@linux.intel.com>
Signed-off-by: Chao Song <chao.song@linux.intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ 833.106967] kernel: IO error in rt700_jack_detect_handler, ret -16
in
https://sof-ci.01.org/softestpr/PR684/build716/devicetest/?model=CML_RVP_SDW&testcase=check-suspend-resume-5 is unrelated thesofproject/linux#2943
@@ -335,7 +335,7 @@ is_sof_used() | |||
# a wrapper to journalctl with required style | |||
journalctl_cmd() | |||
{ | |||
journalctl -k -q --no-pager --utc --output=short-monotonic \ | |||
sudo journalctl -k -q --no-pager --utc --output=short-monotonic \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aiChaoSONG I just had a look a recent ChromeOS image (less than a couple weeks old) and I found zero trace of journalctl
, only rsyslogd
... can you explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time I tried sof-test on chrome, there was journalctl
. I have no idea why they remove journalctl in later chrome image, but there is a new tool for log, craslog
, which works just like journalctl
.
https://chromium.googlesource.com/chromiumos/platform2/+/HEAD/croslog
edit: looks there is a bug in journalctl, so they design a new tool.
https://bugs.chromium.org/p/chromium/issues/detail?id=1066706
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right: there was journalctl but only for a short time. With your help I found a bit more info, see #576
These two patches make check-playback/capture test cases can run on Chrome smoothly. suppose sof-test is downloaded to /usr/local, and other dependencies are installed with chromebrew