ipc: dai: extend Zephyr native drivers api to ipc/dai.c #5899
Conversation
This patch will extend Zephyr native drivers api to ipc dai files and full flow with dma release will be supported Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
| @@ -257,7 +257,11 @@ void dai_dma_release(struct comp_dev *dev) | |||
| if (dd->chan) { | |||
| /* remove callback */ | |||
| notifier_unregister(dev, dd->chan, NOTIFIER_ID_DMA_COPY); | |||
| #if CONFIG_ZEPHYR_NATIVE_DRIVERS | |||
There was a problem hiding this comment.
@lgirdwood one open: not sure If we want to support ipc3 dai with native drivers?
There was a problem hiding this comment.
@lgirdwood do we plan to deprecate IPC3 in the future in favor of IPC4?
There was a problem hiding this comment.
@lgirdwood one open: not sure If we want to support ipc3 dai with native drivers?
Yes we need to support IPC3 as there is no current TSC decision to deprecate IPC3
There was a problem hiding this comment.
@lgirdwood do we plan to deprecate IPC3 in the future in favor of IPC4?
That's a TSC decision, the if/when/how of IPC deprecation and planning. Good topic for next TSC though.
| @@ -257,7 +257,11 @@ void dai_dma_release(struct comp_dev *dev) | |||
| if (dd->chan) { | |||
| /* remove callback */ | |||
| notifier_unregister(dev, dd->chan, NOTIFIER_ID_DMA_COPY); | |||
| #if CONFIG_ZEPHYR_NATIVE_DRIVERS | |||
There was a problem hiding this comment.
@lgirdwood one open: not sure If we want to support ipc3 dai with native drivers?
Yes we need to support IPC3 as there is no current TSC decision to deprecate IPC3
| @@ -257,7 +257,11 @@ void dai_dma_release(struct comp_dev *dev) | |||
| if (dd->chan) { | |||
| /* remove callback */ | |||
| notifier_unregister(dev, dd->chan, NOTIFIER_ID_DMA_COPY); | |||
| #if CONFIG_ZEPHYR_NATIVE_DRIVERS | |||
There was a problem hiding this comment.
@lgirdwood do we plan to deprecate IPC3 in the future in favor of IPC4?
That's a TSC decision, the if/when/how of IPC deprecation and planning. Good topic for next TSC though.
| @@ -229,7 +237,7 @@ static void dai_dma_position_init(struct dai_data *dd) | |||
|
|
|||
| int dai_config(struct comp_dev *dev, struct ipc_config_dai *common_config, | |||
| void *spec_config) | |||
| {trace_point(9); | |||
| { | |||
There was a problem hiding this comment.
oh, looks like this sneaked in....
There was a problem hiding this comment.
Minor nit: ideally a separate commit
|
CI is good. @juimonen good for you too ? |
There was a problem hiding this comment.
As a late comment to #5610 , the intent of CONFIG_ZEPHYR_NATIVE_DRIVERS is not very clear. The description implies this is a working option, but in practise this option cannot be used to build a fully functional image until all uses of DMA support both Zephyr and legacy (i.e. this and follow PRs).
But with that confusion still present in the tree, this code seems good to go.
| @@ -229,7 +237,7 @@ static void dai_dma_position_init(struct dai_data *dd) | |||
|
|
|||
| int dai_config(struct comp_dev *dev, struct ipc_config_dai *common_config, | |||
| void *spec_config) | |||
| {trace_point(9); | |||
| { | |||
There was a problem hiding this comment.
Minor nit: ideally a separate commit
|
@kv2019i that was the goal for CONFIG_ZEPHYR_NATIVE_DRIVERS to use extra kconfig until everything works perfectly, otherwise we would just use __ ZEPHYR __ |
This patch will extend Zephyr native drivers api usage
to ipc dai files and full flow with dma release will be supported