Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adding a warning for using firefox over chrome. #182

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

varoonp123
Copy link
Contributor

We want to discourage firefox because wasm and audio seem to work better on chrome and are pretty bad right now in firefox.

@LordDeatHunter can you provide some input on the html+css? I probably should have run prettier in a separate commit. I am not so comfortable with front end stuff.
Screenshot from 2024-04-22 23-39-27

…ourage firefox because wasm and audio seem to work better on chrome and are pretty bad right now in firefox
@LordDeatHunter
Copy link
Collaborator

LordDeatHunter commented Apr 23, 2024

I sent you updated files on discord, since I can't modify your fork :)

@varoonp123
Copy link
Contributor Author

If you can, make a PR from a branch on your fork :)

@LordDeatHunter
Copy link
Collaborator

LordDeatHunter commented Apr 24, 2024

varoonp123#2
Hopefully this is what you meant 😄 tho IMO it's a bit extra unnecessary effort making a fork of a fork.

edit: Updated image for reference:
image

edit 2:
i posted a screenshot instead of a vid, there's also a "pulsing" animation on the red part background, as well as some effects on the 2 buttons (chrome link and close)

@varoonp123
Copy link
Contributor Author

@LordDeatHunter Looks great! Much better than what my backend brain could do on my own.

  1. I tried but was unable to make the red box a tad smaller so that it doesnt cover the top of the "Thetawave" logo/gif.
  2. How do yall feel about using an "x" icon instead of writing out "Close" and a "warning" icon heroicons are pretty decent and free

I meant make a PR from your fork into the main repo.

# HTTPS is fine because you dont need to push directly to the main repo. HTTPS let you read/clone but 
# DOES NOT let you push to their repo
git clone https://github.com/thetawavegame/thetawave.git && cd thetawave
git remote add vp https://github.com/varoonp123/thetawave.git 
git remote add cds https://github.com/cdsupina/thetawave.git 

# THIS MUST BE SSH/git so you can push to your fork
git remote add dh git@github.com:LordDeatHunter/thetawave.git

# Pulls in recent branches/commits into the local git db whenever you want them
# but doesnt make any changes to your local repo. I fetch right before I want to branch
git fetch vp
git fetch dh
git fetch cds
git fetch origin

# Branch off of me with a new branch name. I use the `-b` a ton
git checkout -b ui/chromeWarningAssist remotes/vp/ui/chromeWarning
echo "Do the things and commit"

# Push to your fork. Then you can PR into the thetawavegame/thetawave repo.
# You can also PR from your fork into ANY fork of the main repo 
git push dh ui/chromeWarningAssist

@LordDeatHunter
Copy link
Collaborator

  1. I don't think this is that big of an issue, considering that you kinda need to close the popup before continuing. I can still shrink it a bit if you'd like?
  2. Sure, I can see what fits
  3. Ah, that works 😅 I find it more convenient with branches, but sure, I can redirect the merge target of the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants