client: Handle updating root with keys that do not match the local meta #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is not deferred, a failing Assert inside of f will cause signed.IsExpired to not get reset. A failing Assert triggers Goexit which calls deferred functions before the goroutine exits (it is essentially a silent panic). Signed-off-by: Jonathan Rudenberg <jonathan@titanous.com>
This ensures that we can update even if the local root is expired and the remote root trusts new keys. For sanity, we decode any local metadata versions without checking signatures. Closes #39 Signed-off-by: Jonathan Rudenberg <jonathan@titanous.com>
|
LGTM |
titanous
added a commit
that referenced
this pull request
Jan 23, 2015
client: Handle updating root with keys that do not match the local meta
rdimitrov
pushed a commit
to rdimitrov/go-tuf
that referenced
this pull request
Jan 25, 2024
* feat(log): add global default logger Signed-off-by: Marvin Drees <marvin.drees@9elements.com> * feat(log): exchange logger in library code Signed-off-by: Marvin Drees <marvin.drees@9elements.com> * feat(log): remove logrus from testutil Signed-off-by: Marvin Drees <marvin.drees@9elements.com> * feat(log): replace logrus in example code Signed-off-by: Marvin Drees <marvin.drees@9elements.com> * chore(log): run go mod tidy for new logger Signed-off-by: Marvin Drees <marvin.drees@9elements.com> * test: add tests for logger set/get functions Signed-off-by: Marvin Drees <marvin.drees@9elements.com> --------- Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
rdimitrov
pushed a commit
that referenced
this pull request
Jan 29, 2024
* feat(log): add global default logger Signed-off-by: Marvin Drees <marvin.drees@9elements.com> * feat(log): exchange logger in library code Signed-off-by: Marvin Drees <marvin.drees@9elements.com> * feat(log): remove logrus from testutil Signed-off-by: Marvin Drees <marvin.drees@9elements.com> * feat(log): replace logrus in example code Signed-off-by: Marvin Drees <marvin.drees@9elements.com> * chore(log): run go mod tidy for new logger Signed-off-by: Marvin Drees <marvin.drees@9elements.com> * test: add tests for logger set/get functions Signed-off-by: Marvin Drees <marvin.drees@9elements.com> --------- Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40
Version downgrade attack during this scenario is not tested, as it is very unlikely (it would require intentionally signing a metadata file with the wrong version, which makes no sense). The version decode step was verified manually, as it would be very tricky to test (if you have a simple way of testing, suggestions welcome).