Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: macos runners are missing older pythons #2618

Closed
jku opened this issue Apr 24, 2024 · 0 comments · Fixed by #2619
Closed

workflows: macos runners are missing older pythons #2618

jku opened this issue Apr 24, 2024 · 0 comments · Fixed by #2619
Labels
bug github_actions Pull requests that update GitHub Actions code

Comments

@jku
Copy link
Member

jku commented Apr 24, 2024

Githubs new (arm) macos runners do not have older python versions. This means test suite is failing.

in securesystemslib we just stopped testing old python on mac and windows: secure-systems-lab/securesystemslib#797. I think that's a reasonable solution since the full matrix is overkill:

  • testing all pythons on linux means we're not using too new features
  • testing the newest python on on mac and windows means we know we're not introducing new linuxisms in the code base

We should do something similar here.
@jku jku added bug github_actions Pull requests that update GitHub Actions code labels Apr 24, 2024
@jku jku mentioned this issue Apr 24, 2024
Merged
2 tasks
@jku jku changed the title worlkflows: macos runners are missing older pythons workflows: macos runners are missing older pythons Apr 24, 2024
@jku jku mentioned this issue Apr 24, 2024
Merged
@jku jku linked a pull request Apr 24, 2024 that will close this issue
workflows: Only test old Pythons on linux #2619
Merged
lukpueh added a commit to in-toto/demo that referenced this issue May 9, 2024
@lukpueh
Upadate tested Python versions on ci
d873e27 
- Remove 3.7, add 3.11 to match in-toto
- Only test on 3.11 on macos, for the same reasons as
  theupdateframework/python-tuf#2618

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workflows: Only test old Pythons on linux jku/python-tuf
1 participant
@jku