Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Add awk magic to GH changelog generation #2602

Merged
merged 1 commit into from Apr 25, 2024

Conversation

jku
Copy link
Member

@jku jku commented Apr 6, 2024

  • Create a changelog file with awk
  • Add both "dist" and "changelog" to GH artifact
  • This changes how the artifact is built: Now the dist directory is inside the artifact (instead of the contents of dist being in the artifact): this means the default path now works for download-artifact
  • Dump changelog into the release body

This is obviously a bit more complicated... but I believe the typical failure mode is a successful release run, the changelog could just be empty (if e.g. CHANGELOG.md is not well formed).

@coveralls
Copy link

coveralls commented Apr 6, 2024

Pull Request Test Coverage Report for Build 8828808586

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.605%

Totals Coverage Status
Change from base Build 8828661670: 0.0%
Covered Lines: 1473
Relevant Lines: 1498

💛 - Coveralls

@jku
Copy link
Member Author

jku commented Apr 8, 2024

Adding a bit more detail: this is something I wanted for tuf-on-ci so did here as well. If others think this is unnecessary complexity that's fine by me.

.github/workflows/cd.yml Outdated Show resolved Hide resolved
@jku
Copy link
Member Author

jku commented Apr 24, 2024

tests will fail due to #2618

* Create a changelog file with awk
* Add both "dist" and "changelog" to artifact
* This changes the artifact handling: Now the dist
  directory is inside the artifact (instead of the contents
  of the directory being in the directory): this means the
  default path now works for `download-artifact`
* Dump changelog into the release body

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku
Copy link
Member Author

jku commented Apr 25, 2024

rebased on main

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! 🪄

@lukpueh lukpueh merged commit 970ddf9 into theupdateframework:develop Apr 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants