tuf/repository_tool: Return delegated bin_name during modifications #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier for consumers of repository_tool to mark the appropriate delegated bin as dirty when using delegated targets. Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
force-pushed
the
ww/return-bin-name-when-delegating
branch
from
78decd0
to
65fd02c
Compare
trishankatdatadog
approved these changes
Jun 1, 2020
|
N.B.: This is obviated by #1038, but provides a stopgap until that's ready and merged (or a larger refactor occurs). |
Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
force-pushed
the
ww/return-bin-name-when-delegating
branch
from
6043f6a
to
4327a98
Compare
Signed-off-by: William Woodruff <william@trailofbits.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #: None (raised on chat).
Description of the changes being introduced by the pull request:
This makes it easier for consumers of
repository_toolto mark theappropriate delegated bin as dirty when using delegated targets.
Please verify and check that the pull request fulfills the following
requirements:
I wasn't sure how to go about adding tests for this; I can look into the
test_repository_tool.pytests to see what can be done.