-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automatic issue closing #1152
Conversation
PS: As proof that On the other prs it doesn't show that. |
I like this change. Not least of all because I often forget to review and close associated issues when merging PRs. @lukpueh is there a reason we haven't used this auto-closing reference style before now? |
I and others have used them in the past, but it was the responsibility of the PR author to use the add the keyword. |
b38e004
to
c4d8475
Compare
c4d8475
to
e036612
Compare
e036612
to
b049eea
Compare
Thanks to @jku for being skeptical here! He asked me if I have tried to close automatically an issue with the last variant we all liked: I decided to have a look and try this in my own private repository.
DOESN'T automatically close the issue what DOES automatically close the issue is to use I updated this pr accordingly. |
Why not just use the documented syntax, i.e. without the colon? |
It's a personal preference. For me, it looks better with a colon.
Should I remove the colon? |
You are quoting an outdated GitHub Enterprise doc. The one I linked above is the latest and does not mention colons anymore.
I lean towards yes, but I wouldn't insist. ;) |
This pr aims to fix the issue that there are occurrences when a pr is merged, but the issues that it mentions that it fixes are not automatically closed by GitHub. According to their documentation: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword "Fixes" is a keyword that should fix this. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
b049eea
to
a4d6329
Compare
@lukpueh updated the pr with your recommendations and edited both my pr and commit message to reference to the new documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
Fixes issue #: None
Description of the changes being introduced by the pull request:
This pr aims to fix the issue that there are occurrences
when a pr is merged, but the issues that it mentions
that it fixes are not automatically closed by GitHub.
According to their documentation:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
Fixes
is a keyword that should resolve this.Please verify and check that the pull request fulfills the following
requirements: