Making the process of updating metadata a little bit more flexible #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make the process of downloading metadata files more flexible, finding mirrors and the actual download were moved to a so-called handler class. With that change, it is possible to load a file from a specific commit of a git repository for example Signed-off-by: Renata <vrenata8@gmail.com>
renatav
force-pushed
the
updater_metadata_refactoring
branch
from
46a7607
to
6de2740
Compare
renatav
force-pushed
the
updater_metadata_refactoring
branch
2 times, most recently
from
e22e73c
to
690b686
Compare
lukpueh
reviewed
Mar 26, 2019
tuf/developer_tool.py
Outdated
| @@ -391,6 +391,7 @@ def status(self): | |||
| self._log_status(self.project_name, signable, self.repository_name) | |||
|
|
|||
| except securesystemslib.exceptions.Error as e: | |||
| # pylint: disable=unsubscriptable-object | |||
There was a problem hiding this comment.
OT: This seems to be the reason why the current TUF@develop build is failing. IMO it should be fixed in a separate PR. Such a fix should probably also evaluate, whether pylint has a point here.
There was a problem hiding this comment.
#839 resolves this issue. (Sorry, folks.)
renatav
force-pushed
the
updater_metadata_refactoring
branch
from
3298bce
to
6de2740
Compare
|
Thank you for the contribution. Due to imminent refactor efforts this code is unlikely to merge, but we would very much welcome your input and engagement on our refactor plans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
client/updater.pywas slightly refactored in order to make the process of updating metadata files a bit more flexible. This flexibility is only related to how the files are downloaded and does not impact validation. Finding mirrors and the actual download were moved to a so-called handler class.With that change, it is possible to implement the majority of the updater which would use a git repository to store metadata files. An example of that implementation can be seen here.
Please verify and check that the pull request fulfills the following
requirements: