Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version 0.12.0 #921

Merged

Conversation

lukpueh
Copy link
Member

@lukpueh lukpueh commented Sep 20, 2019

TODO

  1. Wait for securesystemslib 0.12.0 to be released on PyPI
  2. Merge Explicitly encode data passed to securesystemslib.keys #917 and Remove uses of securesystemslib.util.TempFile #918 to adapt to breaking changes in securesystemslib
  3. Rebase this release PR onto develop
  4. Release tuf 0.12.0-dev0
    Alternatively, and if preferred, release as 1.0.0-dev0 instead (requires changing the version numbers in CHANGELOG.md, setup.py and __init__.py)

@trishankatdatadog trishankatdatadog added this to the 0.12.0 milestone Oct 2, 2019
@lukpueh
Copy link
Member Author

lukpueh commented Oct 3, 2019

Update:
The TUF team has decided that the next release will be 0.12.0 (w/o dev suffix), under the condition that we add a disclaimer about TUF's currently limited protection against slow retrieval attacks. See #928 for a proposal. (cc @trishankatdatadog, @JustinCappos @mnm678 )

@JustinCappos JustinCappos marked this pull request as ready for review October 3, 2019 12:13
setup.py Outdated
@@ -81,7 +81,7 @@

setup(
name = 'tuf',
version = '0.11.2.dev3', # If updating version, also update it in tuf/__init__.py
version = '0.12.0-dev0', # If updating version, also update it in tuf/__init__.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = '0.12.0-dev0', # If updating version, also update it in tuf/__init__.py
version = '0.12.0', # If updating version, also update it in tuf/__init__.py

Copy link
Member

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change these version strings, right?

tuf/__init__.py Outdated
@@ -2,7 +2,7 @@
# setup.py has it hard-coded separately.
# Currently, when the version is changed, it must be set in both locations.
# TODO: Single-source the version number.
__version__ = "0.11.2.dev3"
__version__ = "0.12.0-dev0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__version__ = "0.12.0-dev0"
__version__ = "0.12.0"

@lukpueh
Copy link
Member Author

lukpueh commented Oct 3, 2019

@JustinCappos, yes absolutely. Thanks for the reminder! I would have done it, when rebasing to integrate a merged #928.

@@ -1,5 +1,19 @@
# Changelog


## v0.12.0-dev0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove -dev0

@lukpueh
Copy link
Member Author

lukpueh commented Oct 3, 2019

@trishankatdatadog wants to get #885 in before we bump to 0.12.0. #885 is already finished and reviewed. All that's missing is a test.

@trishankatdatadog trishankatdatadog changed the title Bump version 0.12.0-dev0 Bump version 0.12.0 Oct 3, 2019
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Copy link
Member

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, @lukpueh is the man

@JustinCappos JustinCappos merged commit 6138395 into theupdateframework:develop Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants