Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap 4 trust pinning #1

Merged

Conversation

trishankkarthik
Copy link
Contributor

Begin a PR to merge TAP 4 (Trust Pinning).

@awwad
Copy link
Contributor

awwad commented Sep 14, 2016

https://github.com/theupdateframework/taps/blob/awwad-tap-0004-trust-pinning/tap4.md#pin-file

It's a subtle point, but the two comment lines here may be slightly misleading:

{
  "repositories": {
    "django": {
      // metadata would be at https://repository.djangoproject.com/metadata/
      // targets would be at  https://repository.djangoproject.com/targets/
      "url": "https://repository.djangoproject.com/",

Where the metadata and targets directories are expected to be is defined on a mirror-to-mirror basis in the repository_mirrors argument to the tuf.client.updater.Updater constructor, and so is flexible beyond this point. You could say "might be at" rather than "would be at". Three mirrors for the same (django, say) repository may have different directories for metadata or targets.

@trishankkarthik
Copy link
Contributor Author

On 14 September 2016 at 16:27, Sebastien Awwad notifications@github.com
wrote:

https://github.com/theupdateframework/taps/blob/
awwad-tap-0004-trust-pinning/tap4.md#pin-file

It's a subtle point, but the two comment lines here may be slightly
misleading:

{
"repositories": {
"django": {
// metadata would be at https://repository.djangoproject.com/metadata/
// targets would be at https://repository.djangoproject.com/targets/
"url": "https://repository.djangoproject.com/",

Where the metadata and targets directories are expected to be is defined on
a mirror-to-mirror basis
in the repository_mirrors argument to the
tuf.client.updater.Updater constructor, and so is flexible beyond this
point. You could say "might be at" rather than "would be at". Three mirrors
for the same (django, say) repository may have different directories for
metadata or targets.

Ah, didn't know that. Please go ahead and edit it!

@trishankkarthik trishankkarthik merged commit 51a6181 into theupdateframework:master Sep 14, 2016
@trishankkarthik
Copy link
Contributor Author

Woops, accidentally closed it. Just go ahead and edit master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants