Review interposition PR #254 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er class in tuf.interposition.updater
…r in interposition.updater
Made few changes after adding InvalidConfiguration Exception into tuf.__init__ Also made changes in comments
Added comments in tuf.interposition.UpdaterController Changed the code depending on configuration.hostname to configuration.network_location
Instead of making a set of repositiory mirror hostname, a set of repository mirror network location is created.
…er.UpdaterController
…f Logger format in Logger is changed to 'msg'+repr()
Modified the docstrings of interposition's Exception classes to be less specific.
Add missing docstring labels (to be fully populated in a future pull request that includes unit tests and that validates arguments. Add missing header block. Renamed 'Logger' object to 'logger, to be consistent with the rest of the modules. Minor formatting edits.
Fix issues with 'configuration' variable name and incorrect reference to 'six.moves.urllib.request.Request'.
vladimir-v-diaz
changed the title
vladimir-v-diaz
added a commit
that referenced
this pull request
Feb 10, 2015
Review interposition PR #254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO (separate PR): unit test for
configuration.py,__init__.py(possibly refactor), and populate docstring placeholders inconfiguration.py.