Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for consuming WCIF #236

Merged
merged 47 commits into from Jan 5, 2018
Merged

Add support for consuming WCIF #236

merged 47 commits into from Jan 5, 2018

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Sep 8, 2017

Please download a jar file to test this out here!

A gif is worth a thousand pictures:

2017-12-21_13 25 02_breq

Now that thewca/worldcubeassociation.org#1856 has gone live, TNoodle can finally be able to figure out exactly what scrambles you need for a competition, rather than asking for them.

This PR adds a new, React Redux based UI to TNoodle. You can log in via WCA OAuth and be presented with a list of a upcoming competitions that you have the power to generate scrambles for. (If you're offline or just don't want to use the new UI, you can still access the old UI.)

There's still a bit of work left before this is ready to be merged up, I'll be tracking the remaining work here:

  • Teach people about the staging=true url parameter for testing stuff out

After we merge up this PR, we'll tackle this other issues (just for polish purposes):

@Laura-O
Copy link
Member

Laura-O commented Dec 22, 2017

I have been following the gif and I get an error message when downloading scrambles (using OS X 10.13 with Java 9.01)

java.lang.AssertionError: en translation key of not found
	at net.gnehzr.tnoodle.utils.GwtSafeUtils.azzert(GwtSafeUtils.java:77)
	at net.gnehzr.tnoodle.server.webscrambles.Translate.translate(Translate.java:78)
	at net.gnehzr.tnoodle.server.webscrambles.Translate.translate(Translate.java:102)
	at net.gnehzr.tnoodle.server.webscrambles.ScrambleRequest.addFmcSolutionSheet(ScrambleRequest.java:595)
	at net.gnehzr.tnoodle.server.webscrambles.ScrambleRequest.addScrambles(ScrambleRequest.java:365)
	at net.gnehzr.tnoodle.server.webscrambles.ScrambleRequest.createPdf(ScrambleRequest.java:285)
	at net.gnehzr.tnoodle.server.webscrambles.ScrambleRequest.requestsToZip(ScrambleRequest.java:1257)
	at net.gnehzr.tnoodle.server.webscrambles.ScrambleViewHandler.wrappedService(ScrambleViewHandler.java:247)
	at net.gnehzr.tnoodle.server.SafeHttpServlet.service(SafeHttpServlet.java:41)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:44)
	at winstone.ServletConfiguration.execute(ServletConfiguration.java:249)
	at winstone.RequestDispatcher.forward(RequestDispatcher.java:335)
	at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:378)
	at net.gnehzr.tnoodle.server.HtmlInjectFilter.doFilter(HtmlInjectFilter.java:40)
	at winstone.FilterConfiguration.execute(FilterConfiguration.java:195)
	at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:368)
	at org.tuckey.web.filters.urlrewrite.RuleChain.handleRewrite(RuleChain.java:176)
	at org.tuckey.web.filters.urlrewrite.RuleChain.doRules(RuleChain.java:145)
	at org.tuckey.web.filters.urlrewrite.UrlRewriter.processRequest(UrlRewriter.java:92)
	at org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:389)
	at winstone.FilterConfiguration.execute(FilterConfiguration.java:195)
	at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:368)
	at winstone.RequestDispatcher.forward(RequestDispatcher.java:333)
	at winstone.RequestHandlerThread.processRequest(RequestHandlerThread.java:244)
	at winstone.RequestHandlerThread.run(RequestHandlerThread.java:150)
	at java.base/java.lang.Thread.run(Unknown Source)

Let me know if you need more information or when I should try/test something else.

@jfly
Copy link
Contributor Author

jfly commented Dec 22, 2017

Thanks for pointing that out, @Laura-O! I've fixed that in #252, and updated the link to the jar file in my original post.

@jfly
Copy link
Contributor Author

jfly commented Jan 5, 2018

I sent this out to the Board and team leaders, and they all confirmed that this is working for them.

@viroulep expressed concern that we don't make errors visible in the UI, but I think it's okay for us to ask people to open the developer console and copy paste what they see there. I'm definitely not opposed to someone adding better support for displaying errors, but it's not something I will have the time to work on before the next TNoodle release.

@jfly jfly merged commit 76c42a4 into thewca:master Jan 5, 2018
@jfly jfly deleted the wcif branch January 5, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants