Can I haz progress bar? #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 29, 2020 18:39
|
Awesome! |
|
Maybe front end is over tested. |
campos20
reviewed
Sep 30, 2020
| loadScrambles(endpoint, payload, targetMarker) { | ||
| let that = this; | ||
|
|
||
| return new Promise(function (resolve, reject) { |
There was a problem hiding this comment.
I think that if you use
(resolve, reject) => {
...
}
you'll be able to dismiss the use of that and keep using this. Arrow functions allow this.
There was a problem hiding this comment.
And if you're going to touch it, maybe you could also take care of this other one
gregorbg
force-pushed
the
feature/progress-bar
branch
from
304f4c7
to
03d8851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally touched frontend.