Navigation and other interactive buttons now freeze when generating scrambles #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campos20
reviewed
Nov 9, 2020
| @@ -19,6 +19,7 @@ const mapStateToProps = (store) => ({ | |||
| scramblingProgressTarget: store.scramblingProgressTarget, | |||
| scramblingProgressCurrent: store.scramblingProgressCurrent, | |||
| fileZipBlob: store.fileZipBlob, | |||
| generatingScrambles: store.generatingScrambles, | |||
There was a problem hiding this comment.
Travis is complaining that this is duplicated. Could you please fix it?
There was a problem hiding this comment.
Hi, I made a new commit and pushed it onto this fork. Did it work? thanks!
|
I decided to undo all my unnecessary commits to make everything more clear. Hopefully this works now! Sorry for the confusion - I'm new to this. |
|
This is looking great! I have just one more request for you Use 2014PRID01 and navigate to SCA Road Trip - Sydney 2021 This competition has FMC. Then, you can open the translation and then start generating scrambles. Input boxes are not disabled. Could you please disable it as well? I think it's this one, if I'm not mistaken |
|
Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.