Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNF for remaining attempts after disqualification. Fix #392. #485

Merged
merged 2 commits into from
Nov 16, 2017

Conversation

Claster
Copy link
Contributor

@Claster Claster commented Oct 29, 2017

Motivation for DNF:

  1. We have several cases in the past where results were recorded as DNF.
  2. Introducing brand new result DQ can break every piece of code in the world that relies on DNF and DNS as the only ones being less than zero.

@@ -91,6 +91,7 @@ Note: Because Article and Regulation numbers are not reassigned when Regulations
- 2i2b) The competitor must not interact with (e.g. operate, hold, wear) any active camera. Exception: the competitor may wear a camera mounted on their head, as long as it is out of their sight and it is clear that they are not interacting with it (apart from wearing it).
- 2j) The WCA Delegate may disqualify a competitor from a specific event.
- 2j1) If a competitor is disqualified from an event for any reason, they are not eligible for any more attempts in the event.
- 2j1a) The results of all remaining attempts in this event are recorded as DNF.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This or the? :P We use the above, and this below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We rarely use "this" in the regulations, so "the event" sounds better for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still possible to suggest here? I would propose that this phrase was part of 2j1, inside ( ):

2j1) If a competitor is disqualified from an event for any reason, they are not eligible for any more attempts in the event (i.e. the results of all remaining attempts in this event are recorded as DNF).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a reason for us? :-)

I think it's not "i.e.", otherwise we would not need this addition?
Also, it's quite an important regulation (considering that it was decided inconsistently in the past), so hiding it in parentheses might not be a good idea.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is that this seems like a continuation or an explanation of the previous sentence.

"they can't do more attempts, and those remaining attempts are marked as DNF"

I don't feel too strong about this...if kept separately, I would suggest to add "In this case" to the beginning of 2j1a

@lgarron
Copy link
Member

lgarron commented Nov 7, 2017

Motivation for DNF:

We have several cases in the past where results were recorded as DNF.
Introducing brand new result DQ can break every piece of code in the world that relies on DNF and DNS as the only ones being less than zero.

I do not consider these to be good reasons.

Past cases are unambiguous mistakes based on the current Regulations/Guidelines: https://www.worldcubeassociation.org/regulations/guidelines.html#9f5+

If we think DQ is clearer, I don't think that we should use DNF instead of DQ just because existing software doesn't handle it yet.

We can update the few pieces of important existing software (CubeComps, WCA site), and then adopt this afterwards.

@jfly
Copy link
Contributor

jfly commented Nov 7, 2017

👍 to @lgarron's comments! I don't understand the specifics of this particular discussion, but in general, we cannot decide to do the wrong thing because we are afraid to change our software systems.

@Laura-O
Copy link
Member

Laura-O commented Nov 10, 2017

Some thoughts on this:
In the past, disqualifications have been published anonymously by the WDC if the competitor was under 18 years old. Using "DQ" for disqualified attempts would add this information permanently to a WCA profile, so the information that the competitor was disqualified would be public.

Do we want that and is this in line with the spirit of the WCA?

@lgarron
Copy link
Member

lgarron commented Nov 10, 2017

In the past, disqualifications have been published anonymously by the WDC if the competitor was under 18 years old. Using "DQ" for disqualified attempts would add this information permanently to a WCA profile, so the information that the competitor was disqualified would be public.

Isn't it already possible to cross-reference the posts in some case?
I just looked up a random case or two, and it's easy to find out whom https://www.worldcubeassociation.org/archive/forum_topics/2008 is referring to.

Is your concern that this would be visible to people who are not looking for it, and that DQ will carry a stigma?

@Laura-O
Copy link
Member

Laura-O commented Nov 10, 2017

Yes, there is a huge difference between reading an old post and being able to track the competitor mentioned in this post, and visiting the profile of specific competitors and knowing that they were disqualified x years ago.

WCA profiles are also ranked high in search results for your name, so it's likely that people who know nothing about speedcubing visit the profile and see disqualified results.

@Claster
Copy link
Contributor Author

Claster commented Nov 13, 2017

  1. Keeping DNF is the least painful solution for everybody;
  2. According to 9f5+, disqualified results should be empty. This, however, will break checks in Workbook Assistant and scripts WRT uses. So as is, this regulation is not applied, so why not to change it?

@Claster
Copy link
Contributor Author

Claster commented Nov 16, 2017

Anybody else wants to comment or approve? ;)

@AlbertoPdRF
Copy link
Contributor

It's fine as it is I think.

LGTM!

@AlbertoPdRF AlbertoPdRF merged commit 8437137 into thewca:Fixes-2017 Nov 16, 2017
@lgarron
Copy link
Member

lgarron commented Nov 18, 2017

I think Laura made a fair point, so I'm also fine with DNF. :-)

@Jambrose777
Copy link
Member

2j1a makes it to where a competitor does not begin an attempt and will still receive a DNF. Is this fundamentally correct? Shouldn't their remaining solves be DNS since they have not attempted them?

@SAuroux
Copy link
Member

SAuroux commented Mar 18, 2018

Yes, it is correct, as this is incorporated into the definition of DNFs. Meanwhile, a DNS would be incorrect (also according to its definition). See 9f4 and 9f5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants