Skip to content

Commit

Permalink
Fixed logic of at_least_senior_member? (#9576)
Browse files Browse the repository at this point in the history
* Fixed logic of at_least_senior_member?

* Unit tests
  • Loading branch information
danieljames-dj committed Jun 26, 2024
1 parent 75c2dde commit db0be02
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app/models/roles_metadata_teams_committees.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ class RolesMetadataTeamsCommittees < ApplicationRecord
has_one :user, through: :user_role

def at_least_senior_member?
user_role.status_rank <= UserRole.status_rank(UserGroup.group_types[:teams_committees], RolesMetadataTeamsCommittees.statuses[:senior_member])
user_role.status_rank >= UserRole.status_rank(UserGroup.group_types[:teams_committees], RolesMetadataTeamsCommittees.statuses[:senior_member])
end
end
22 changes: 22 additions & 0 deletions spec/models/roles_metadata_teams_committees_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# frozen_string_literal: true

require 'rails_helper'

RSpec.describe RolesMetadataTeamsCommittees, type: :model do
describe 'at_least_senior_member?' do
it 'returns false when the role is a WRC member' do
role = FactoryBot.create(:user_role, :active, :wrc_member)
expect(role.metadata.at_least_senior_member?).to be false
end

it 'returns true when the role is a WRC senior member' do
role = FactoryBot.create(:user_role, :active, :wrc_senior_member)
expect(role.metadata.at_least_senior_member?).to be true
end

it 'returns true when the role is a WRC leader' do
role = FactoryBot.create(:user_role, :active, :wrc_leader)
expect(role.metadata.at_least_senior_member?).to be true
end
end
end

0 comments on commit db0be02

Please sign in to comment.