Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ruby 2.4.0 #1114

Closed
jfly opened this issue Jan 20, 2017 · 0 comments · Fixed by #1349
Closed

Upgrade to Ruby 2.4.0 #1114

jfly opened this issue Jan 20, 2017 · 0 comments · Fixed by #1349
Assignees

Comments

@jfly
Copy link
Contributor

jfly commented Jan 20, 2017

Ruby 2.4.0 came out in December.

I just upgraded to Ruby 2.4.0 locally, and ran into the following issue while running "bundle install":

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /home/jeremy/.bundle/ruby/2.4.0/gems/json-1.8.3/ext/json/ext/generator
/usr/bin/ruby -r ./siteconf20170120-20980-175rrec.rb extconf.rb
creating Makefile

current directory: /home/jeremy/.bundle/ruby/2.4.0/gems/json-1.8.3/ext/json/ext/generator
make "DESTDIR=" clean

current directory: /home/jeremy/.bundle/ruby/2.4.0/gems/json-1.8.3/ext/json/ext/generator
make "DESTDIR="
compiling generator.c
generator.c: In function ‘generate_json’:
generator.c:861:25: error: ‘rb_cFixnum’ undeclared (first use in this function)
     } else if (klass == rb_cFixnum) {
                         ^~~~~~~~~~
generator.c:861:25: note: each undeclared identifier is reported only once for each function it appears in
generator.c:863:25: error: ‘rb_cBignum’ undeclared (first use in this function)
     } else if (klass == rb_cBignum) {
                         ^~~~~~~~~~
make: *** [Makefile:242: generator.o] Error 1

make failed, exit code 2

Gem files will remain installed in /home/jeremy/.bundle/ruby/2.4.0/gems/json-1.8.3 for inspection.
Results logged to /home/jeremy/.bundle/ruby/2.4.0/extensions/x86_64-linux/2.4.0/json-1.8.3/gem_make.out

An error occurred while installing json (1.8.3), and Bundler cannot continue.
Make sure that `gem install json -v '1.8.3'` succeeds before bundling.

rails/rails#27450 looks relevant to this.

@jfly jfly self-assigned this Jan 20, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Feb 21, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Mar 9, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Mar 9, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Mar 9, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Mar 9, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue May 5, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue May 5, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue May 5, 2017
This requires upgrading to Rails 5.0.2 for full ruby 2.4 compatibility.
This fixes thewca#1114.
@jfly jfly closed this as completed in #1349 May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant