Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule validations/sanity checks #3335

Open
jfly opened this issue Sep 3, 2018 · 4 comments
Open

Schedule validations/sanity checks #3335

jfly opened this issue Sep 3, 2018 · 4 comments
Labels
PRIORITY: high-priority Should be quickly assigned to someone who can start work immediately/soon project: competition form SERVICE: competition TECH: reactJS Requires knowledge of React TECH: ruby Requires knowledge of Ruby

Comments

@jfly
Copy link
Contributor

jfly commented Sep 3, 2018

(cc-ing @viroulep for his thoughts. This might be redundant with some of his work in #3207, which I have not looked at yet)

Some people have brought up some schedule "validation" they'd like our schedule tool to do. This is a list of them:

@Goosly Goosly mentioned this issue Sep 3, 2018
16 tasks
@Goosly
Copy link
Contributor

Goosly commented Sep 11, 2018

Similarly, FMC/MBLD attempts can start before the previous attempt has finished. This should be forbidden. Note that these attempts may be assigned to different rooms, so it should be checked across all rooms.

@c-goodyear
Copy link
Contributor

The same round being added multiple times should be flagged for the user to know that it has been added multiple times. This can happen by design (bigBLD, seperate stages etc) but can also be a mistake from an organizer/Delegate who then fail to notice it has been appended to the schedule twice.

Currently there is a shading system in place on the round buttons for the schedule. Dark being yet to be appended, light have been appended. My suggestion would be to flag these in a color that is not blue, so it is obvious to those who unintentionally added a second instance of the same round.

@viroulep
Copy link
Member

I've not put much thoughts into this yet, but given we should probably look into an "extensible" solution I'd suggest implementing an extra entry in the menu here:
menu

Which would display the list of sanity checks which fail (with two versions of the icon: one if everything looks good, one with some red eye-catching thingy as soon as one sanity check fails).

@AlbertoPdRF
Copy link
Contributor

If it's visible enough when a sanity check fails, that may be a good idea!

@gregorbg gregorbg added PRIORITY: high-priority Should be quickly assigned to someone who can start work immediately/soon javascript TECH: ruby Requires knowledge of Ruby labels Jun 20, 2021
@dunkOnIT dunkOnIT added the TECH: reactJS Requires knowledge of React label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRIORITY: high-priority Should be quickly assigned to someone who can start work immediately/soon project: competition form SERVICE: competition TECH: reactJS Requires knowledge of React TECH: ruby Requires knowledge of Ruby
Projects
Status: No status
Development

No branches or pull requests

7 participants