Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results Posts - Link Profile in records section #4512

Closed
Jambrose777 opened this issue Aug 21, 2019 · 13 comments
Closed

Results Posts - Link Profile in records section #4512

Jambrose777 opened this issue Aug 21, 2019 · 13 comments
Assignees
Labels
META: good first issue Small/easy change which is a good introduction to working in the WCA repo

Comments

@Jambrose777
Copy link
Member

Jambrose777 commented Aug 21, 2019

Request to add a link to a person's profile whenever they are mentioned in the records section of a results post.

This shouldn't be too hard, but instead of this:

Caio Hideaki Sato won V ETEC Jacareí Open 2019 with an average of 7.35 seconds. Iuri Grangeiro Carvalho finished second (8.25) and Antonio Gabriel Freitas da Silva finished third (8.33).
South American records: Caio Hideaki Sato‎ 3x3x3 Cube 7.35 (average), Iuri Grangeiro Carvalho‎ 3x3x3 One-Handed 9.64 (average).

We'd have:

Caio Hideaki Sato won V ETEC Jacareí Open 2019 with an average of 7.35 seconds. Iuri Grangeiro Carvalho finished second (8.25) and Antonio Gabriel Freitas da Silva finished third (8.33).
South American records: Caio Hideaki Sato‎ 3x3x3 Cube 7.35 (average), Iuri Grangeiro Carvalho‎ 3x3x3 One-Handed 9.64 (average).

Should be a simple change, the harder part is figuring out how to modify all old posts to this new format.

@AlbertoPdRF AlbertoPdRF added the META: good first issue Small/easy change which is a good introduction to working in the WCA repo label Aug 21, 2019
@jfly
Copy link
Contributor

jfly commented Aug 22, 2019

Updating the post should be pretty straightforward. Updating old posts doesn't feel worth the effort to me.

I say this on every discussion about our posts: I am not convinced they're worth keeping around. We're so big now, I don't think anyone actually looks at them.

@AlbertoPdRF
Copy link
Contributor

I think we should have this conversation before letting more issues pile up. These posts in particular (not the competition announcement ones) add information that can't be found anywhere else:

  • The podium of the competition (i.e. who has won the competition)
  • A summary of the records set at the competition

I would be fine with adding this information to the competition page itself in some way and remove the posts altogether. Other opinions?

@SAuroux
Copy link
Member

SAuroux commented Aug 23, 2019

I would be ok with that @AlbertoPdRF .

As for the unique information contained in results posts, I actually see only two distinct pieces that should probably be stored in the Competitions table:

  • main event
  • uploader

@jfly
Copy link
Contributor

jfly commented Aug 24, 2019

I quite like the idea of storing main event and uploader, adding the podium information to the competition home page, and getting rid of the results posts!

@AlbertoPdRF
Copy link
Contributor

@thewca/board would you agree with us going that way?

Also, what would we do with old posts? Get the information we need from them and then delete them or something else?

@jfly
Copy link
Contributor

jfly commented Aug 24, 2019

Yeah, doing some sort of backfill and then removal of the old posts sounds like a good goal to me.

@AlbertoPdRF
Copy link
Contributor

And for the announcements ones I guess we should also save the announcer on the database and that's it, right?

@cubewhiz
Copy link
Member

I'm fine with getting rid of these.

What is the rationale for storing uploader and announcer?

@AlbertoPdRF
Copy link
Contributor

What is the rationale for storing uploader and announcer?

Some reasons I can think of:

  • Credit the users who do the work
  • Help resolve systematic mistakes of a user that have been found out a posteriori

By the way, I'm working on this.

@SAuroux
Copy link
Member

SAuroux commented Aug 25, 2019

I am also currently using this information to track the activity of my team members.

In general, I'd say that traceability is the key argument.

@cubewhiz
Copy link
Member

Seems reasonable. I expect the announcement and results posting date will still continue to be collected as usual?

@AlbertoPdRF
Copy link
Contributor

I expect the announcement and results posting date will still continue to be collected as usual?

Yep!

@cubewhiz
Copy link
Member

Great, thanks for the clarification.

Anyway, I fully support getting rid of the competition announcements/results on the home page. It's definitely not worth investing more time into features for those posts if we're all on board to get rid of them.

AlbertoPdRF added a commit to AlbertoPdRF/worldcubeassociation.org that referenced this issue Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
META: good first issue Small/easy change which is a good introduction to working in the WCA repo
Projects
None yet
Development

No branches or pull requests

5 participants