Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow delegates to post reports on or after the last day of a competition #737

Closed
jfly opened this issue Jun 27, 2016 · 10 comments · Fixed by #1245
Closed

Allow delegates to post reports on or after the last day of a competition #737

jfly opened this issue Jun 27, 2016 · 10 comments · Fixed by #1245
Assignees
Labels
META: good first issue Small/easy change which is a good introduction to working in the WCA repo

Comments

@jfly
Copy link
Contributor

jfly commented Jun 27, 2016

A comment from Ron:

Software team: I had no Post the report but yesterday. Could it be that this button only appears the day after the competition? If so, please change this, I want to be able to post reports immediately after the competition.

My response:

The idea was to not allow posting a report until after the competition, but since we don't actually have competition schedules, it's impossible for us to know when it's over on the day that it is scheduled to end.

I don't see any problem with letting delegates post their reports anytime after the competition has started.

@jfly jfly added the META: good first issue Small/easy change which is a good introduction to working in the WCA repo label Jun 27, 2016
@SAuroux
Copy link
Member

SAuroux commented Jun 27, 2016

I disagree with posting reports after a competition has started. Why not just allow posting reports after the start of the last calendar day of a competition, i.e. one day earlier than we allow now? This solves the problem and minimizes the risk of reports being submitted too early.

@pedrosino
Copy link
Contributor

I disagree with posting reports after a competition has started. Why not just allow posting reports after the start of the last calendar day of a competition, i.e. one day earlier than we allow now? This solves the problem and minimizes the risk of reports being submitted too early.

For one-day competitions this is essentially "...after a competition has started".

@SAuroux
Copy link
Member

SAuroux commented Jun 27, 2016

Thanks for pointing out the obvious Pedro... ;)

What is interesting is, that this is not the same for multi-day competitions.

@pedrosino
Copy link
Contributor

Yeah, I meant that your proposal works only partly :)

I don't have a strong preference here...maybe the competition ends early and the delegate wants to submit the report on the same day. This would incur in the problem at #720 which doesn't seem to have an easy solution...

@SAuroux
Copy link
Member

SAuroux commented Jun 27, 2016

You are confusing me. Why does my proposal only work partially?

Of course I was aware of that this changes nothing for 1-day comps, for 2-day or 3-day comps however I do not see why a report would need to be submitted before the last calendar day of that competition. Thus I think "last calendar day of a competition" makes more sense than "first calendar day of a competition", that's all.

@pedrosino
Copy link
Contributor

Now you are confusing me. You said "I disagree with posting reports after a competition has started.", but that's "inevitable" for 1-day comps with your proposal.

Anyway, I'm not opposed to the proposal.

@SAuroux
Copy link
Member

SAuroux commented Jun 27, 2016

Ok, then I will formulate more precisely: I disagree with the rule "beginning with first calendar day of a competition". Instead I propose the rule "beginning with last calendar day of a competition". The difference only affects X-day competitions with X > 1.

@larspetrus
Copy link
Contributor

Assuming I've understood the problem from this discussion, this could be
less frustrating with simple UI changes.

If you just don't show a button where the user expects to find it, he is
left wondering why. Is this a bug? Am I misremembering where this button
is? Did the button get moved? Should I have configured something earlier to
make the button appear? Etc.

This is why currently unavailable UI elements should usually be greyed out
instead of removed.

In this case it sounds like a brief explanation would also be useful. "The
report can be posted 17:00 GMT (6h 14m from now)"

On Mon, Jun 27, 2016 at 5:27 AM, Sébastien Auroux notifications@github.com
wrote:

Ok, then I will formulate more precisely: I disagree with the rule
"beginning with first calendar day of a competition". Instead I propose the
rule "beginning with last calendar day of a competition". The difference
only affects X-day competitions with X > 1.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#737 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAuGK4jkWTljptHNbjZofJuGyK75oLPfks5qP8HGgaJpZM4I-6lL
.

Procrastinators - the Leaders of Tomorrow

@SAuroux
Copy link
Member

SAuroux commented Jan 29, 2017

I just finished the report of a competition that I have delegated this weekend and that has now already ended and the fact that I cannot just submit this report is extremely annoying. Can this simple fix please be tackled soon?

@jfly
Copy link
Contributor Author

jfly commented Jan 30, 2017

Just talked to @SAuroux about this, we both agree that the best thing to do here is to allow posting delegate reports on or after the last day of a competition.

@larspetrus brings up a good point. It might be more friendly to provide the user with a submit button that spits out an error when you try to click it.

@jfly jfly changed the title Allow delegates to post reports anytime after a competition has *started*, rather than ended Allow delegates to post reports on or after the last day of a competition Jan 30, 2017
@jfly jfly self-assigned this Jan 30, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Jan 30, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Jan 30, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Jan 31, 2017
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Feb 1, 2017
@jfly jfly closed this as completed in #1245 Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
META: good first issue Small/easy change which is a good introduction to working in the WCA repo
Projects
None yet
4 participants