-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow delegates to post reports on or after the last day of a competition #737
Comments
I disagree with posting reports after a competition has started. Why not just allow posting reports after the start of the last calendar day of a competition, i.e. one day earlier than we allow now? This solves the problem and minimizes the risk of reports being submitted too early. |
For one-day competitions this is essentially "...after a competition has started". |
Thanks for pointing out the obvious Pedro... ;) What is interesting is, that this is not the same for multi-day competitions. |
Yeah, I meant that your proposal works only partly :) I don't have a strong preference here...maybe the competition ends early and the delegate wants to submit the report on the same day. This would incur in the problem at #720 which doesn't seem to have an easy solution... |
You are confusing me. Why does my proposal only work partially? Of course I was aware of that this changes nothing for 1-day comps, for 2-day or 3-day comps however I do not see why a report would need to be submitted before the last calendar day of that competition. Thus I think "last calendar day of a competition" makes more sense than "first calendar day of a competition", that's all. |
Now you are confusing me. You said "I disagree with posting reports after a competition has started.", but that's "inevitable" for 1-day comps with your proposal. Anyway, I'm not opposed to the proposal. |
Ok, then I will formulate more precisely: I disagree with the rule "beginning with first calendar day of a competition". Instead I propose the rule "beginning with last calendar day of a competition". The difference only affects X-day competitions with X > 1. |
Assuming I've understood the problem from this discussion, this could be If you just don't show a button where the user expects to find it, he is This is why currently unavailable UI elements should usually be greyed out In this case it sounds like a brief explanation would also be useful. "The On Mon, Jun 27, 2016 at 5:27 AM, Sébastien Auroux notifications@github.com
Procrastinators - the Leaders of Tomorrow |
I just finished the report of a competition that I have delegated this weekend and that has now already ended and the fact that I cannot just submit this report is extremely annoying. Can this simple fix please be tackled soon? |
Just talked to @SAuroux about this, we both agree that the best thing to do here is to allow posting delegate reports on or after the last day of a competition. @larspetrus brings up a good point. It might be more friendly to provide the user with a submit button that spits out an error when you try to click it. |
See discussion here: https://github.com/thewca/worldcubeassociation.org/pull/1206/files#r98485399. This fixes thewca#737.
See discussion here: https://github.com/thewca/worldcubeassociation.org/pull/1206/files#r98485399. This fixes thewca#737.
A comment from Ron:
My response:
The text was updated successfully, but these errors were encountered: