Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to sign in page in the accoutn confirmation email #4943

Merged
merged 1 commit into from Dec 25, 2019
Merged

Fix link to sign in page in the accoutn confirmation email #4943

merged 1 commit into from Dec 25, 2019

Conversation

jonatanklosko
Copy link
Member

Reported by Roman Ostapenko, we've been linking to the wrong page for quite a long time.
On a side note I'm wondering if it makes sense to include sentence about sign in possibility, as the purpose of the email is to confirm the account and it's quite obvious how to proceed after that.

Copy link
Member

@viroulep viroulep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one of the test actually looks for proper localization so we'll need the Spanish localization right away I think.
@moralsh @Ivan-Brigidano , could one of you give us what we should use for "login form" in Spanish?

@Ivan-Brigidano
Copy link
Member

@viroulep do you mean the translation?

@moralsh
Copy link
Contributor

moralsh commented Dec 21, 2019

I'd say "formulario de entrada" or "formulario de conexión", pick the first one unless @Ivan-Brigidano or someone else prefers another one.

@Ivan-Brigidano
Copy link
Member

I'd say "formulario de entrada" or "formulario de conexión", pick the first one unless @Ivan-Brigidano or someone else prefers another one.

@moralsh I have just asked it to Mar Gallego. She said that the best translation would be "Formulario de inicio de sesión". It sound good to me

@moralsh
Copy link
Contributor

moralsh commented Dec 21, 2019

if length of the text isn't an issue it certainly is a better translation

@viroulep
Copy link
Member

I did mean the translation, and for better context the full text is:

After activation you may log in to the website of the World Cube Association: login form
(with "login form" being a link to the login page)

Does this change anything or should Jonatan use the translation suggested by Mar?

@Ivan-Brigidano
Copy link
Member

I did mean the translation, and for better context the full text is:

After activation you may log in to the website of the World Cube Association: login form
(with "login form" being a link to the login page)

Does this change anything or should Jonatan use the translation suggested by Mar?

No, the translation suggested by Mar works fine here

@jonatanklosko
Copy link
Member Author

Sorry for the delay, fixed!

@jonatanklosko jonatanklosko merged commit a4a41ba into thewca:master Dec 25, 2019
@jonatanklosko jonatanklosko deleted the update-confirmation-email-link branch December 25, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants