Remove problematic SET statements from the developer database dump #5027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the database developer dump gives the following warning on production:
The dump includes two problematic statements:
SET @@GLOBAL.gtid_purged
andSET @@SESSION.SQL_LOG_BIN
, I guess that's been the case since we upgraded MySQL version. While loading the dump locally may work if the given database user has full permissions, it fails on the staging due to lack of the necessary permissions. Setting the option doesn't include these options, which correctly removes the warning and also omits the problematicSET
statements, so I believe that's a reasonable thing to do.@tussosedan please let me know if there's any reason we wouldn't want doing so =)