Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove problematic SET statements from the developer database dump #5027

Merged
merged 1 commit into from Jan 1, 2020

Conversation

@jonatanklosko
Copy link
Member

jonatanklosko commented Jan 1, 2020

Currently the database developer dump gives the following warning on production:

Warning: A partial dump from a server that has GTIDs will by default include the GTIDs of all transactions, even those that changed suppressed parts of the database. If you don't want to restore GTIDs, pass --set-gtid-purged=OFF. To make a complete dump, pass --all-databases --triggers --routines --events.

The dump includes two problematic statements: SET @@GLOBAL.gtid_purged and SET @@SESSION.SQL_LOG_BIN, I guess that's been the case since we upgraded MySQL version. While loading the dump locally may work if the given database user has full permissions, it fails on the staging due to lack of the necessary permissions. Setting the option doesn't include these options, which correctly removes the warning and also omits the problematic SET statements, so I believe that's a reasonable thing to do.

@tussosedan please let me know if there's any reason we wouldn't want doing so =)

@tussosedan

This comment has been minimized.

Copy link
Contributor

tussosedan commented Jan 1, 2020

As these options have to do with replication, it seems safe to get rid of them for the dev dump. Thanks!

@jonatanklosko jonatanklosko merged commit e8accf9 into thewca:master Jan 1, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.109%
Details
@jonatanklosko jonatanklosko deleted the jonatanklosko:update-dumper branch Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.