Update feet rank and UI #5099
Merged
Update feet rank and UI #5099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record I did run CAD locally to check how it looked (good). |
jonatanklosko
approved these changes
Jan 26, 2020
|
Thanks for the review Jonatan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5028, supersedes #5097.
In order to let the WCAT be able to edit events and rounds for past competitions which have deprecated events, I adjusted the
normalizeWcifEventsto first build a list of wcifEvents from the official list of events, and then add back all the remaining events in wcifEvents (which are therefore all deprecated).This is not quite ideal since we still don't have a clue about which events were official at what time, but at least it should remove feet without hindering WCAT/WRT/Delegates work.
In order for this to properly work, we need to synchronize with the WRT to run CAD which will effectively update the rankings and profile pages.
I'm not too sure about the sum of rank computation but I believe it also uses only official events.
If it doesn't, well it will just wait until we get rid of the php code.