Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the now non-existent announcement link #5146

Merged
merged 2 commits into from Feb 7, 2020

Conversation

DanielEgdal
Copy link
Member

Since announcement posts aren't made any more there should not be an empty line in the mails sent to organizers.
I assume this should fix everything, but there might be an open end somewhere referencing the link?

Removing the now non-existent announcement link.
@jonatanklosko
Copy link
Member

You also need to remove the actual usage of the phrase (actually it should've already been gone, but it's a leftover):

<p>
<%= t 'users.mailer.competition_announcement_email.link' %>
</p>

@DanielEgdal
Copy link
Member Author

Thanks, makes sense. It should be good now.

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonatanklosko jonatanklosko merged commit 7afb019 into thewca:master Feb 7, 2020
@DanielEgdal DanielEgdal deleted the patch-1 branch February 7, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants