Migrate WCT China to roles #9241
Conversation
danieljames-dj
force-pushed
the
migrate-wct-china-to-roles
branch
from
2d64e1a
to
d7c30e4
Compare
| @@ -98,7 +98,7 @@ | |||
|
|
|||
| trait :wct_china_member do | |||
| after(:create) do |user, options| | |||
| FactoryBot.create(:team_member, team_id: Team.wct_china.id, user_id: user.id, team_senior_member: options.team_senior_member, team_leader: options.team_leader) | |||
There was a problem hiding this comment.
You're losing two important bits of information (senior member, team leader). For WCT China, this is probably okay because they don't have so strict structures, but what about future role migrations?
There was a problem hiding this comment.
For WCT China, the status is supposed to be member in testcases used so it's fine. For future migration, I'm planning to use multiple traits like wrt_member, wrt_senior_member, etc.
There was a problem hiding this comment.
It may be worth to compare this with the WST Admin migration code and come up with one (or multiple helper) function(s) like "def migrate_team_to_roles" in lib somewhere
There was a problem hiding this comment.
Makes sense, I've moved this method to lib so can be reused for upcoming migrations.
No description provided.