Create separate panel for Delegates #9332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
reviewed
May 1, 2024
kr-matthews
reviewed
May 2, 2024
gregorbg
requested changes
May 2, 2024
Done |
gregorbg
approved these changes
May 2, 2024
| <Header as="h2">Important Links</Header> | ||
| <List> | ||
| {IMPORTANT_LINKS.map(({ title, link }) => ( | ||
| <ListItemLink key={title.replace(/ /g, '')} title={title} link={link} /> |
There was a problem hiding this comment.
Why not just take the link URL itself as a key?
There was a problem hiding this comment.
That's cleaner, accepted the suggestion. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, most of the panels are already migrated to panel. But there are two panels which are not yet migrated to React - staff panel and delegate panel. This PR is to migrate the Delegate Panel to react. The staff panel will be migrated in a later PR.