Add preferred contact mode for teams/committees #9333
Conversation
danieljames-dj
force-pushed
the
preferred_contact_mode
branch
from
3079a03
to
6e25cbe
Compare
| @@ -3,6 +3,12 @@ | |||
| class GroupsMetadataTeamsCommittees < ApplicationRecord | |||
| has_one :user_group, as: :metadata | |||
|
|
|||
| enum :preferred_contact_mode, { | |||
| no_public_way: "no_public_way", | |||
There was a problem hiding this comment.
Naming choice here feels a bit odd. What about private?
There was a problem hiding this comment.
Changed to no_contact as per discussion.
| if (group.metadata.friendly_id === 'wrt') { | ||
| return contactRecipientUrl('results_team'); | ||
| } | ||
| return contactRecipientUrl('communications_team'); |
There was a problem hiding this comment.
Lots of hard-coded strings. At the very least, the references to results_team and communications_team should be exposed through some ContactForm constants.
Ideally, this would use the new "preferred contact mode" feature like so: (pseudo-code)
if (group.metadata.preferred_contact_mode === 'private') { // perhaps store string as constant somewhere
return contactRecipientUrl(group.metadata.friendly_id);
}
return contactRecipientUrl(someFallback);
The parameter to pass to contactRecipientUrl is a bit tricky here, because we generally use friendly IDs for T/Cs but the contact form expects humanized values instead (might be worth changing this?!)
Also not sure what fallback should be or whether we even need it. If a T/C set their preferred communication mode to private, they should definitely have a corresponding contact form recipient. So there really shouldn't be the case where we even need a fallback.
There was a problem hiding this comment.
Now I'm thinking should I change the contact recipient to friendly ID, because it's safer to do this now than later. What do you think?
config/locales/en.yml
Outdated
| @@ -788,7 +789,7 @@ en: | |||
| wac: "The WAC is responsible for maintaining feedback and communication between the WCA Community and the WCA Staff. They maintain the WCA Forums and summarize surveys and attempt to increase reach across the worldwide community." | |||
| contacts: | |||
| title: "WCA Contact Form" | |||
| faq_note_html: 'Before making an inquiry, you may wish to take a look at our <a href="/faq">Frequently Asked Questions</a>! If you wish to contact a specific committee or team not listed here, you can find their contact information on <a href="/teams-committees-councils">this page</a>.' | |||
| faq_note_html: 'Before making an inquiry, you may wish to take a look at our <a href="/faq">Frequently Asked Questions</a>! If you wish to contact a specific committee or team not listed here, you can find their contact information on <a href="/teams-committees-councils">this page</a> (Some committee/team might have also opted out from contacting, you will not be able to contact them).' | |||
There was a problem hiding this comment.
This extra snippet of text should appear on the T/C overview page directly. Perhaps you can change the previously existing "you can find their contact information on" to something like "you can contact them on this page", which still holds true even with email opt-out (we don't guarantee that you will be able to contact them via email, but if they opt out you will still be able to ultimately contact them via the form)
There was a problem hiding this comment.
Actually the thing is there are cases like WCAT where they don't want public to contact them in any way. I've changed it to another way, does it look good now?
| change_column_default :groups_metadata_teams_committees, :preferred_contact_mode, GroupsMetadataTeamsCommittees.preferred_contact_modes[:email] | ||
| UserGroup.teams_committees_group_wrt.metadata.update!(preferred_contact_mode: GroupsMetadataTeamsCommittees.preferred_contact_modes[:contact_form]) | ||
| UserGroup.teams_committees_group_wct.metadata.update!(preferred_contact_mode: GroupsMetadataTeamsCommittees.preferred_contact_modes[:contact_form]) | ||
| UserGroup.teams_committees_group_wcat.metadata.update!(preferred_contact_mode: GroupsMetadataTeamsCommittees.preferred_contact_modes[:no_public_way]) |
There was a problem hiding this comment.
Follow-up change if you rename the constant as per my other comment above
Currently the email IDs of all the teams/committees are exposed. There can be some teams/committees who prefers not to show their email address instead allow to contact only via contact form. Then there can be some other teams/committees who prefers not to have their email ID in public. To accommodate all their needs, added a column in groups_metadata_teams_committees.