Including users and groups when loading user_roles #9550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
requested changes
Jun 21, 2024
Comment on lines
53
to
54
| # Paginating the list by sending only first 100 elements unless mentioned in the API. | ||
| paginate json: roles |
There was a problem hiding this comment.
This change seems like it was included in your previous pagination PR.
Is there maybe a chance you didn't include the latest changes from main in your currentPR branch?
There was a problem hiding this comment.
Oops I don't know how this came, removed now.
| @@ -19,6 +19,9 @@ class Api::V0::UserRolesController < Api::V0::ApiController | |||
| group_id = params[:groupId] | |||
| user_id = params[:userId] | |||
|
|
|||
| # For post filtering, user & group is needed. | |||
| active_record = active_record.includes([:user, :group]) | |||
There was a problem hiding this comment.
First, includes takes varargs, so .includes(:user, :group) will work.
Second, if you know that these two are going to be includes'd anyways no matter what, then you can just declare active_record = UserRole.includes(...) directly at the top of the method above.
There was a problem hiding this comment.
Oh ya, thanks for that. Implemented.
danieljames-dj
force-pushed
the
precompute-users-groups
branch
from
030552d
to
0fa4ab4
Compare
danieljames-dj
force-pushed
the
precompute-users-groups
branch
from
0fa4ab4
to
fc0bae2
Compare
gregorbg
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user data and group data is used for post filtering, hence precomputing them for the roles list API.