Add error to contact form if submission fails #9564
Conversation
| @@ -66,6 +68,7 @@ export default function ContactForm({ loggedInUserData }) { | |||
| }, [selectedContactRecipient]); | |||
|
|
|||
| if (saving) return <Loading />; | |||
| if (saveError) return <Errored error={saveError} />; | |||
There was a problem hiding this comment.
I think the error handler of our useSaveAction returns the actual error object. This means that the Errored property here might end up just displaying: "An error occured! Details: [Object object]".
Have you tested this? You can temporarily modify the backend controller to just execute raise "Something went horribly wrong!" directly as the first line, to simulate an error. And then see how the frontend behaves.
There was a problem hiding this comment.
Yes, it returns error object. If I do raise "Something went horribly wrong!", it will show some weird error:
But instead for return render status: :bad_request, json: { error: "Invalid arguments" }, I'll get following:
The last one is the current behavior. Is this fine or do you have an alternative suggestion?
(I also just realized I missed to add return for that error in contact_controller. Added it now)
Currently if there is an error for the contact form submission, we are not informing the user of the same. This PR is to achieve that.