Skip to content

Commit

Permalink
Fixed #1177 - In gapfill feedback, images are not shown in lightbox w…
Browse files Browse the repository at this point in the history 
…hen clicked
  • Loading branch information
@torinfo
torinfo committed Nov 22, 2022
1 parent 327b381 commit 6606e6f
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions modules/xerte/parent_templates/Nottingham/models_html5/gapFill.html
View file
Expand Up @@ -420,6 +420,7 @@

$("#feedbackTxt #txt").html(x_addLineBreaks(x_currentPageXML.getAttribute("feedback")));
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
gapFill.audioFbResize(true);
});

Expand Down Expand Up @@ -479,6 +480,7 @@
if ($targetHolder.find("input.correct").length == $targetHolder.find("input").length) {
$("#feedbackTxt #txt").html(x_addLineBreaks(x_currentPageXML.getAttribute("feedback")));
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
gapFill.audioFbResize(true);
}

Expand Down Expand Up @@ -598,6 +600,7 @@
$("#submitBtn").hide();
$("#feedbackTxt #txt").html(x_addLineBreaks(x_currentPageXML.getAttribute("feedback")));
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
gapFill.audioFbResize(true);

finished = true;
Expand Down Expand Up @@ -649,6 +652,7 @@
$("#submitBtn").hide();
$("#feedbackTxt #txt").html(x_addLineBreaks(x_currentPageXML.getAttribute("feedback")));
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
gapFill.audioFbResize(true);

finished = true;
Expand Down Expand Up @@ -820,6 +824,7 @@
$feedbackTxt.fadeIn();
gapFill.audioFbResize(true);
gapFill.dragDropSubmit();
x_pageContentsUpdated();
}
}

Expand Down Expand Up @@ -915,6 +920,7 @@
if (forced != true) {
$("#feedbackTxt #txt").html('<p>' + x_addLineBreaks(x_currentPageXML.getAttribute("gapFillIncomplete") != undefined && x_currentPageXML.getAttribute("gapFillIncomplete") != "" ? x_currentPageXML.getAttribute("gapFillIncomplete") : "Please complete the exercise.") + '</p>');
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
}

// an attempt (even if partial) has been made
Expand Down Expand Up @@ -973,6 +979,7 @@
$("#feedbackTxt #txt").html(x_addLineBreaks(x_currentPageXML.getAttribute("feedback")));
$feedbackTxt.fadeIn();
gapFill.audioFbResize(true);
x_pageContentsUpdated();

finished = true;

Expand Down Expand Up @@ -1012,12 +1019,14 @@
$("#feedbackTxt #txt").html('<p>' + gapFillPartWrong + '</p>');
}
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
}

// if force tracking mode is on then you must fully complete before checking answers
} else {
$("#feedbackTxt #txt").html('<p>' + x_addLineBreaks(x_currentPageXML.getAttribute("gapFillIncomplete") != undefined && x_currentPageXML.getAttribute("gapFillIncomplete") != "" ? x_currentPageXML.getAttribute("gapFillIncomplete") : "Please complete the exercise.") + '</p>');
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
}
}
};
Expand All @@ -1030,6 +1039,7 @@
if (forced != true) {
$("#feedbackTxt #txt").html('<p>' + x_addLineBreaks(x_currentPageXML.getAttribute("gapFillIncomplete") != undefined && x_currentPageXML.getAttribute("gapFillIncomplete") != "" ? x_currentPageXML.getAttribute("gapFillIncomplete") : "Please complete the exercise.") + '</p>');
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
}

// an attempt (even if partial) has been made
Expand Down Expand Up @@ -1098,6 +1108,7 @@
$("#showBtn,#submitBtn").hide();
$feedbackTxt.fadeIn();
gapFill.audioFbResize(true);
x_pageContentsUpdated();

finished = true;

Expand All @@ -1108,6 +1119,7 @@
$("#feedbackTxt #txt").html('<p>' + gapFillPartWrong + '</p>');
}
$feedbackTxt.fadeIn();
x_pageContentsUpdated();

if (this.isTracked) {
$("#submitBtn").hide();
Expand All @@ -1119,6 +1131,7 @@
} else {
$("#feedbackTxt #txt").html('<p>' + x_addLineBreaks(x_currentPageXML.getAttribute("gapFillIncomplete") != undefined && x_currentPageXML.getAttribute("gapFillIncomplete") != "" ? x_currentPageXML.getAttribute("gapFillIncomplete") : "Please complete the exercise.") + '</p>');
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
}
}
};
Expand All @@ -1131,6 +1144,7 @@
if (forced != true) {
$("#feedbackTxt #txt").html('<p>' + x_addLineBreaks(x_currentPageXML.getAttribute("gapFillIncomplete") != undefined && x_currentPageXML.getAttribute("gapFillIncomplete") != "" ? x_currentPageXML.getAttribute("gapFillIncomplete") : "Please complete the exercise.") + '</p>');
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
}

// an attempt (even if partial) has been made
Expand Down Expand Up @@ -1262,6 +1276,7 @@
$("#labelHolder").hide();
$("#feedbackTxt #txt").html(x_addLineBreaks(x_currentPageXML.getAttribute("feedback")));
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
gapFill.audioFbResize(true);
finished = true;
} else {
Expand All @@ -1271,12 +1286,14 @@
$("#feedbackTxt #txt").html('<p>' + x_addLineBreaks(x_currentPageXML.getAttribute("gapFillPartWrongTracking") != undefined && x_currentPageXML.getAttribute("gapFillPartWrongTracking") != "" ? x_currentPageXML.getAttribute("gapFillPartWrongTracking") : "Your correct answers are shown in green.") + '</p>');
}
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
}

// if force tracking mode is on then you must fully complete before checking answers
} else {
$("#feedbackTxt #txt").html('<p>' + x_addLineBreaks(x_currentPageXML.getAttribute("gapFillIncomplete") != undefined && x_currentPageXML.getAttribute("gapFillIncomplete") != "" ? x_currentPageXML.getAttribute("gapFillIncomplete") : "Please complete the exercise.") + '</p>');
$feedbackTxt.fadeIn();
x_pageContentsUpdated();
}
}
}
Expand Down

0 comments on commit 6606e6f

Please sign in to comment.