Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show title issues in Bootstrap navigators #1024

Closed
ronm123 opened this issue Jun 4, 2021 · 2 comments
Closed

show title issues in Bootstrap navigators #1024

ronm123 opened this issue Jun 4, 2021 · 2 comments

Comments

@ronm123
Copy link
Collaborator

ronm123 commented Jun 4, 2021

Not sure if this has always been an issue or whether it's something that has changed or indeed if it's deliberate for some reason. But it was pointed out to me today that the show title option on a text element inside a bootstrap accordion navigator doesn't work. e.g. it doesn't show that title whether ticked or not. I did some testing and it's a bit more nuanced than that e.g. the nav set to pills or tabs has a different impact to the nav set to accordion or carousel.

To reproduce add a text element and image element to the page with show title enabled - the title as well as content of both elements shows correctly.
Create a navigator below those elements set to accordion and either duplicate or recreate a text and image element with show title enabled inside that accordion pane the title of those elements inside the accordion do not show.
Change the navigator to pills or tabs the titles do now show but inside the navigator much smaller than outside the navigator. That may just be a css issue and may be desirable that the sizes are different inside and outside the navigator.

To summarise the titles don't show in accordion or carousel but do show in pills or tabs but different size to when outside the navigator.

I think we should change this so that if the show title option is checked then the title should show regardless of navigator mode.
Not sure exactly what we should do about the difference in title size inside or outside the navigator and that may vary by theme anyway.

@ronm123 ronm123 added this to the Short-term/desirable milestone Jun 4, 2021
@ronm123 ronm123 changed the title show title issues in Bootstrap show title issues in Bootstrap navigators Jun 4, 2021
@obgeneralao
Copy link

obgeneralao commented Jun 5, 2021

Hi Ron,

I just updated to the latest devel and I still encounter this issue in the bootstrap sidebar navigation since long before. I think it has something to do with the section numbering. It all messes up once the section number starts at 10 and beyond.

Xerte_1

@ronm123
Copy link
Collaborator Author

ronm123 commented Jun 8, 2021

Hi all
so I've investigated the various issues with this and have a solution but having just discussed with Tom it's something we are going to delay until the next dev day because there are implications for existing projects. e.g. if we change the code so that child titles are now showing (regardless of navigator mode) where they weren't before then we potentially have lots of unwanted titles showing. Also I think we need to change from <p><b> to h3 which again could have implications for existing projects. But we have a plan to avoid any consequences for existing projects which we'll discuss on the next dev day.

FayCross added a commit that referenced this issue Sep 8, 2022
… accordion & carousel navigators will work as expected. Existing content added to these navigators will continue to work strangely (video & audio titles always on and other content type titles always off) so that existing projects won't suddenly show titles appearing / disappearing
@FayCross FayCross closed this as completed Sep 8, 2022
torinfo pushed a commit that referenced this issue Sep 14, 2022
… accordion & carousel navigators will work as expected. Existing content added to these navigators will continue to work strangely (video & audio titles always on and other content type titles always off) so that existing projects won't suddenly show titles appearing / disappearing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants