Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashcards and 360 pages do not work in offline export #1270

Closed
torinfo opened this issue Jan 14, 2024 · 1 comment
Closed

Flashcards and 360 pages do not work in offline export #1270

torinfo opened this issue Jan 14, 2024 · 1 comment

Comments

@torinfo
Copy link
Collaborator

torinfo commented Jan 14, 2024

Reported by clients of ours and on forum:

  1. The flashcards do not work anymore in an export zip. They used to work in previous versions
  2. The 360 page does not work in an offline export
@torinfo
Copy link
Collaborator Author

torinfo commented Jan 14, 2024

Solution for 1.
It turns out that the flahscards used to use a script dependency loader $script. There were issues with that loader, so it was replaced by a new loader (loadjs). The problem is that the dependency laoder was loaded by xenith.js and only if the module was NOT an offline module.

I removed the dynamic loading of loadjs.min.js from xenith.js and moved it to plaver_html5/rloObject.htm (like the comment already suggested we should do anyway).

  1. now works,

Solution for 2.
Basically the same problem. The dependency pannellum.js (the viewer we use) was not loaded properly. The model uses $.getScript to load the .js file, but that does not work in an offline context. So pannellum.js is now loaded using the loadjs dependency loader.

Regrettably, that still doesn't solve the issues with the media360 page, because pannellum.js internally uses also something similar as $.getScript and causes a CORS error. It is beyond the scope of this fix to try and remedy that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant