Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site template navigators accordian and carousel don't display pdf #385

Closed
ronm123 opened this issue Sep 24, 2015 · 1 comment
Closed

Site template navigators accordian and carousel don't display pdf #385

ronm123 opened this issue Sep 24, 2015 · 1 comment

Comments

@ronm123
Copy link
Collaborator

ronm123 commented Sep 24, 2015

In the site template if a navigator is added, dfollowed by a pane to which a pdf option is then added this works with the navigator set to tabs or pills but doesn't display the pdf if set to accordian or carousel. Not sure if this has always been the case or is a new bug but obviously it ought to work.

Also looking at how a pdf is displayed normally and inside a navigator tab or pill should we increase the height of the frame or make this a contollable property when authoring?
e.g. I tested changing lines 304 and 448 of /modules/site/parent_templates/site/common/js/application.js and changed pdfDoc height to 600 which seems to be a better default height given that most pdf's are A4 portrait etc.

@thexerteproject
Copy link
Owner

I've fixed both of those, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants