Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lightbox code to each project template and make option available wherever relevant #758

Closed
5 of 9 tasks
ronm123 opened this issue May 16, 2018 · 2 comments
Closed
5 of 9 tasks

Comments

@ronm123
Copy link
Collaborator

ronm123 commented May 16, 2018

As discussed we should include the featherlight.js code in each of the projects and include an option in the editor and page types wherever relevant e.g.

  • add to Target dropdown in editor links menu
  • add to options seen when selecting iframe button in editor
  • add as option on embed content page
  • add as option on hyperlinks page
  • add as option on multiple perspectives
  • add as option on video page
  • add as option on new window page
  • add as option on thumbnail viewer
  • add as option hotspot image connector
@JohnSmith-LT
Copy link
Collaborator

Hi @ronm123, found this while looking through the issues - I had no idea it was this old!

Anyway, I think we've now addressed the first item but is the second item still required and what would the options look like?

Also, what would the option be on the other pages and what would the functionality do?

@FayCross
Copy link
Collaborator

FayCross commented Mar 15, 2024

Closing as although there are other items in list, they are all things that can be done in other ways so no longer needed:

  • add to options seen when selecting iframe button in editor - add normal link and set target to open website in lightbox
  • add as option on embed content page - use new window page instead, or use link with lightbox as target
  • add as option on video page - use new window page, set open in to lightbox and add embed code to HTML optional property
  • add as option on thumbnail viewer - use multiple perspectives (set to grid) instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants