Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate.ts: upgrade devDependencies #4

Merged
merged 1 commit into from
Oct 1, 2018
Merged

generate.ts: upgrade devDependencies #4

merged 1 commit into from
Oct 1, 2018

Conversation

acarabott
Copy link
Contributor

solves issue of build failing, fixes #3

solves issue of build failing
@postspectacular postspectacular merged commit 1233fbb into thi-ng:master Oct 1, 2018
@postspectacular
Copy link
Member

Thanks, @acarabott !!! 🥇 I was actually going to replace webpack w/ parcel (like w/ all the other umbrella example projects), but didn't get to it yet...

at least this works for now!

@acarabott
Copy link
Contributor Author

acarabott commented Oct 1, 2018

👍

Will check out Parcel, in my other projects I moved from Webpack to just compiling to ES6 modules as something in the bundling was increasing audio artefacts on iOS Safari.

@postspectacular
Copy link
Member

hmm.. maybe webpack/babel started polyfilling some constructs it shouldn't have? I had that problem initially with Parcel too, but then learned that I can set a "browerslist" config in package.json to stop it from going all legacy on me :) E.g.

https://github.com/thi-ng/umbrella/blob/master/examples/xml-converter/package.json#L25

@JJ-Atkinson
Copy link

I still have the same errors on my machine. If yall get around to it would be great to have working!

@postspectacular
Copy link
Member

@JJ-Atkinson hey - so sorry for not updating this, I will put a note on the readme that this template is somewhat out of date. There have been hundreds of updates to the umbrella repo meanwhile, incl. some breaking changes to hdom itself, which need to be reflected here in this scaffolding. Time's the enemy! :)

With the release of GH templates I will probably phase out this project soon and replace with a ready to go repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn error on start
3 participants