Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend parsing of SVG path definitions #98

Draft
wants to merge 13 commits into
base: feature/no-org
Choose a base branch
from
Draft

Extend parsing of SVG path definitions #98

wants to merge 13 commits into from

Commits on Feb 20, 2023

  1. Add [failing] tests of SVG path string parsing

    @respatialized
    respatialized committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    31aa7f1 View commit details
    Browse the repository at this point in the history

  2. Expand tests to include geometry objects + successful parsing 

    The W3C triangle example parses correctly according to these tests.
    @respatialized
    respatialized committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    12cdf2d View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Rework coordinate regex to handle two W3C-defined corner cases 

    Quoting from the section of the spec defining the grammar:

"...in the string "M 100-200" ... the first coordinate will
be "100" and the second coordinate will be "-200".

"Similarly, for the string "M 0.6.5"... the first coordinate
will be "0.6" and the second coordinate will be ".5".
    @respatialized
    respatialized committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    71c0d9b View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. The beginning of a new, more general parsing implementation

    @respatialized
    respatialized committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    9d6c579 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Add SVG grid layout export capabilities + annotate example paths

    @respatialized
    respatialized committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    4f5f3a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Expand parsing to handle cases of single-coordinate sequences 

    This is a necessary requirement for the horizontal and vertical move
commands.
    @respatialized
    respatialized committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    285054b View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2023

  1. Add parsing capabilities for curves + arcs; fix some tests

    @respatialized
    respatialized committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    61f848b View commit details
    Browse the repository at this point in the history

  2. A corner case: a move command with no other commands 

    One unresolved question:
should move-only commands parse into Vec2 geometries or return nil?
    @respatialized
    respatialized committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    6a27427 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Add failing tests for unimplemented command geometry types

    @respatialized
    respatialized committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    b43a673 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Include relative info in parsed path + fix command dispatch 

    The geometry tests still indicate that the parsed segments do not
yet have a working geometric implementation.
    @respatialized
    respatialized committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    b159f5c View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Designate specific command names for specific Bézier curve types

    @respatialized
    respatialized committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    12d9b14 View commit details
    Browse the repository at this point in the history

  2. Add more multimethods for segment types 

    Plus, align segment definition with terminology used elsewhere in the library.
    @respatialized
    respatialized committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    8bcc014 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Add "move" segment (which is really just a point) 

    This enables consistent sampling behavior on paths that
consist only of a single move command
    @respatialized
    respatialized committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    88ffa09 View commit details
    Browse the repository at this point in the history