Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test packages + tox.ini #10

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Conversation

russoz
Copy link

@russoz russoz commented Jul 28, 2018

Hi Thiago,

When running the tests on a clean environment we had failure. According to:

https://docs.pytest.org/en/latest/goodpractices.html#integrating-with-setuptools-python-setup-py-test-pytest-runner

we should add pytest and pytest-runner to setup.py. Also added a tox.ini file to help the testing.

@russoz
Copy link
Author

russoz commented Jul 28, 2018

BTW, I tested locally against python3.7 and it worked flawlessly

@codecov
Copy link

codecov bot commented Jul 28, 2018

Codecov Report

Merging #10 into master will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage    83.5%   82.98%   -0.53%     
==========================================
  Files          10       10              
  Lines         570      570              
==========================================
- Hits          476      473       -3     
- Misses         94       97       +3
Impacted Files Coverage Δ
src/nexuscli/nexus_client.py 89.42% <0%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b83eb...1d7f039. Read the comment docs.

@russoz
Copy link
Author

russoz commented Jul 29, 2018

Impacted files show a file that was untouched by this commit 😲

@thiagofigueiro thiagofigueiro merged commit dc42c1e into thiagofigueiro:master Aug 1, 2018
@thiagofigueiro
Copy link
Owner

Thanks for this @russoz! Sorry about the delay. Daytime job's been busy :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants