POC – Fixed #1688 -- Output translatable labels when displaying permissions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
force-pushed
the
ticket_1688
branch
2 times, most recently
from
f90e95e
to
b17492d
Compare
thibaudcolas
changed the title
adamchainz
reviewed
Jun 4, 2023
| return "%s | %s" % (self.content_type, self.name) | ||
| names = { "content_type": self.content_type } | ||
|
|
||
| if "Can add" in self.name: |
There was a problem hiding this comment.
Would startswith be a more accurate check?
Suggested change
| if "Can add" in self.name: | |
| if self.name.startswith("Can add "): |
There was a problem hiding this comment.
Definitely. And the fallback after those conditionals should probably be return "%s | %s" % (self.content_type, _(self.name)), so custom permissions are translate-able (would additionally require people to hard-code a copy of their permission names somewhere in their code for makemessages to pick up).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demos of a potential fix for https://code.djangoproject.com/ticket/1688.
See discussions:
Second PoC (latest), based on django#16053 – resulting labels:
First PoC: see commit 89eb783e46d98d5092840df560c6eb8dc06e27c5. Resulting labels: