Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added random dog pic command #58

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Added random dog pic command #58

merged 4 commits into from
Oct 3, 2022

Conversation

abhishekpatil4
Copy link
Contributor

@abhishekpatil4 abhishekpatil4 commented Oct 3, 2022 •
edited
Loading

Added new command [command]

  • Code is formatted correctly
  • Code is tested before submitting
  • Updated README.md commands list with my new command

Details

[details]

thieleju
thieleju requested changes Oct 3, 2022
View reviewed changes
Copy link
Owner

@thieleju thieleju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @abhishekpatil4!
I requested a small change :)

commands/dogpic.js Outdated Show resolved Hide resolved
@thieleju thieleju mentioned this pull request Oct 3, 2022
Closed
1 task
thieleju
thieleju requested changes Oct 3, 2022
View reviewed changes
commands/dogpic.js Outdated Show resolved Hide resolved
thieleju
thieleju approved these changes Oct 3, 2022
View reviewed changes
Copy link
Owner

@thieleju thieleju left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, I'm merging this now :) 🚀
#44

@thieleju thieleju merged commit b2c870a into thieleju:main Oct 3, 2022
@thieleju thieleju added the hacktoberfest-accepted Your contribution will count to Hacktoberfest 2022 label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thieleju thieleju thieleju approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Your contribution will count to Hacktoberfest 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhishekpatil4 @thieleju