Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use output filename if provided #8

Closed
wants to merge 1 commit into from

Conversation

IdoBar
Copy link

@IdoBar IdoBar commented Oct 2, 2017

Un-commented the if() statement to check if an output filename was provided.
Currently a new unique date-based name is being created regardless of the user input.

Un-commented the if() statement to check if an output filename was provided.
Currently a new unique date-based name is being created regardless of the user input.
@thierrygosselin
Copy link
Owner

Hi Ido, I had voluntarily commented the filename argument in write_snprelate, I've had issues with users providing filenames, I decided to have it decided by default by the function.

I'm going to fix this, however note that in my next release this will not be available. I'm removing SNPRelate dependencies from all of my packages.

I love the package and personally I've never had problem installing/using... apart from the problem on how the Fst is calculate, which is still unresolved on my end.

Lately, I came to the conclusion that It was way too much work for me trying to troubleshoot it's installation for users.

I will leave the code write_snprelate with a link to download on my GitHub page for interested users.

Cheers,
Thierry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants