Fixed rubyforge bug #11294 which didn't allow boolean searches to work.

git-svn-id: svn+ssh://rubyforge.org/var/svn/arext/trunk@116 5128a5ed-121c-0410-8d5c-98af306bc9be

ar-extensions/db/migrate/generic_schema.rb

@@ -53,6 +53,7 @@
     t.column :updated_at, :time
     t.column :updated_on, :datetime
     t.column :topic_id, :integer
+    t.column :for_sale, :boolean, :default => true
   end  
 
   create_table :languages, :force=>true do |t|

ar-extensions/db/migrate/mysql_schema.rb

@@ -24,6 +24,7 @@
     t.column :updated_at, :datetime
     t.column :updated_on, :datetime
     t.column :topic_id, :integer
+    t.column :for_sale, :boolean, :default => true
   end
   execute "ALTER TABLE books ADD FULLTEXT( `title`, `publisher`, `author_name` )"
 

ar-extensions/db/migrate/version.rb

@@ -1,4 +1,4 @@
 class SchemaInfo < ActiveRecord::Base
   set_table_name 'schema_info'
-  VERSION = 8
+  VERSION = 10
 end

ar-extensions/lib/ar-extensions/finders.rb

@@ -57,8 +57,8 @@ def sanitize_sql_from_hash( hsh ) #:nodoc:
           sql = nil
           result = ActiveRecord::Extensions.process( key, val, self )
           if result
-            conditions << result.sql if result.sql
-            values.push( result.value ) if result.value
+            conditions << result.sql
+            values.push( result.value ) 
           else
             conditions << "#{table_name}.#{connection.quote_column_name(key.to_s)} #{attribute_condition( val )} "
             values << val

ar-extensions/tests/fixtures/books.yml

@@ -8,6 +8,7 @@ second:
   title: "The Voyage of Jerle Shannara: Ilse Witch"
   publisher: Del Rey
   author_name: Terry Brooks
+  for_sale: false
 third:
   id: 3
   title: "The Voyage of Jerle Shannara: Jarka Ruus"

ar-extensions/tests/fixtures/unit/active_record_base_finders/books.yml

@@ -10,6 +10,7 @@ second:
   publisher: Del Rey
   author_name: Terry Brooks
   created_at: 2007-01-10 21:20:00
+  for_sale: false
 third:
   id: 3
   title: "The Voyage of Jerle Shannara: Jarka Ruus"

ar-extensions/tests/test_finders.rb

@@ -275,7 +275,12 @@ def to_sql( caller )
   end
 
   def test_find_should_not_break_proper_string_escapes
-    assert Book.find_or_create_by_title_and_publisher_and_author_name( "Book1%20Something", "Publisher%20", "%20Author%20" );
+    assert Book.find_or_create_by_title_and_publisher_and_author_name( "Book1%20Something", "Publisher%20", "%20Author%20" )
+  end
+
+  def test_find_should_not_break_boolean_searches
+    record = Book.find_by_author_name_and_for_sale('Terry Brooks', false)
+    assert_equal books(:second), record, "wrong record"
   end
 
 end