BIG-16 #close - implement token verification function #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 5, 2018 10:18
Really there is nothing here but a vague function definition.
* Wrap errors in provider * Provide implementation for ValidateToken method * Make provider test external again (i.e. test from `bigiot_test` package.
This allows re-activating an existing offering without having to send the full description everytime
get back from git if required
This was just added to help me build the string, but should be deleted
Remove some commented out code blocks
BIG-32 #close Activate offering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meat of this PR is in the
ValidateTokenmethod which uses a JWT library from square to parse and validate tokens where a valid token is: a) signed by the provider's secret, and b) has not expired. The library ensures a valid signing algorithm is used I think.Other than that all that is in this pr is using the github.com/pkg/errors library to wrap errors