BIG-32 #close Activate offering #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 10, 2018 17:50
This allows re-activating an existing offering without having to send the full description everytime
get back from git if required
chespinoza
suggested changes
Jan 10, 2018
offering.go
Outdated
| expirationTime time.Time | ||
| ) | ||
|
|
||
| // { "query" : "mutation activateOffering { activateOffering ( input: { id: \"Thingful_SM-TestProvider-RandomNumberOffering2\" |
There was a problem hiding this comment.
Seems that this comments should be deleted isn't?
This was just added to help me build the string, but should be deleted
Remove some commented out code blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to our provider type which allows re-activating offerings without sending the full description every time.
This PR also re-organises some tests to improve coverage