Merge pull request #11024 from thingsboard/fix/subs-cleanup

Refactor stale subs cleanup on ClusterTopologyChangeEvent

application/src/main/java/org/thingsboard/server/service/subscription/DefaultTbLocalSubscriptionService.java

@@ -155,7 +155,15 @@ public void onApplicationEvent(ClusterTopologyChangeEvent event) {
                 }
             });
             if (!staleSubs.isEmpty()) {
-                staleSubs.forEach(subscriptionsByEntityId::remove);
+                subsLock.lock();
+                try {
+                    staleSubs.forEach(entityId -> {
+                        subscriptionsByEntityId.remove(entityId);
+                        entityUpdates.remove(entityId);
+                    });
+                } finally {
+                    subsLock.unlock();
+                }
             }
         }
     }