[3.3.3] correct sending lwm2m logs / device update improvements #5878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condition
if (response instanceof LwM2mResponse && !(response instanceof ReadResponse))
is incorrect becauseObserveResponse extends ReadResponse
and we cant send the ObserveResponse logs.Condition
if (md.getSessionInfo().getDeviceProfileIdMSB() != deviceProfileIdMSB && md.getSessionInfo().getDeviceProfileIdLSB() != deviceProfileIdLSB)
is incorect because for example we have 2 different UUIDs: "ad1dbb20-6a1f-11ec-b273-15d4f8a71990" and "1bba1e10-6a21-11ec-b273-15d4f8a71990" but least significant bits are the same.